[BEAM-11618-11619-11605-11468-][Website revamp]Implemented capability matrix, powered by, beam practises, feedback component #13858
Conversation
|
Review: @TheNeuralBit |
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
I have some initial comments/questions. I still need to look over the templates but I'm out of time for today.
I tried to look at the new capability matrix in the website preview (http://apache-beam-website-pull-requests.storage.googleapis.com/13858/index.html) but clicking Documentation > Runners doesn't work.
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> |
There was a problem hiding this comment.
Do we have any copy for Scio?
There was a problem hiding this comment.
unfortunately no
There was a problem hiding this comment.
@nevillelyh is there any chance you or someone else involved with Scio could provide a blurb about it for our new "powered by" card? For reference the blurb for Klio is:
Developed at Spotify and built on top of Apache Beam for Python, Klio is an open source framework that lets researchers and engineers build smarter data pipelines for processing audio and other media files, easily and at scale.
There was a problem hiding this comment.
That is for Klio, a different, similarly named library from Spotify :)
There was a problem hiding this comment.
Another issue I just noticed in the staged website, the footer is centered:
Merge of website-revamp fixed this
There was a problem hiding this comment.
Let's file a jira to make sure we get some copy for Scio at some point
Are u sure? I just pulled this branch and capability is working fine (also incognito) |
Yes I'm sure. Note I didn't pull the branch and build the website locally, I'm going off the one that the "Website Stage GCS" job built, here: http://apache-beam-website-pull-requests.storage.googleapis.com/13858/index.html When I go to that page and click Documentation > Runners, it takes me to http://apache-beam-website-pull-requests.storage.googleapis.com/13858/documentation/runners/capability-matrix/index.html, which doesn't exist |
|
Another issue I just noticed in the staged website, the footer is centered: |
Jakub-Sadowski
changed the title
|
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
I have a couple of comments here, not finished looking it over though
website/www/site/layouts/shortcodes/documentation/capability-matrix-single.html
Show resolved
Hide resolved
website/www/site/layouts/partials/section-menu/en/contribute.html
Outdated
Show resolved
Hide resolved
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
A few more comments here
website/www/site/content/en/documentation/runners/capability-matrix/_index.md
Show resolved
Hide resolved
...ation/runners/capability-matrix/additional-common-features-not-yet-part-of-the-beam-model.md
Outdated
Show resolved
Hide resolved
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> |
There was a problem hiding this comment.
Let's file a jira to make sure we get some copy for Scio at some point
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
I'm still seeing some scrolling issues with the capability matrix. Other than that and some other minor requests this is looking good.
website/www/site/layouts/shortcodes/documentation/capability-matrix-single.html
Show resolved
Hide resolved
| PipelineResult which generally will be a job descriptor for your data | ||
| processing engine, providing methods for checking its status, canceling it, and | ||
| waiting for it to terminate. | ||
|
|
There was a problem hiding this comment.
We need to update the copy on this page and the new page based on this move (e.g. in the new page it says "From here on ...", but this is actually the end of the page). I'll file a jira to do that since I don't think we have time to do it now.
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
2 participants
Implemented:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.