Skip to content

Conversation

@TheNeuralBit
Copy link
Member

@TheNeuralBit TheNeuralBit commented Feb 12, 2021

This reverts #13765, as it breaks SpannerReadIT in Java PostCommit.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

This reverts commit e0ba4dc.
@TheNeuralBit
Copy link
Member Author

Run Java PostCommit

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #13972 (7929d6f) into master (dc29b8c) will increase coverage by 0.05%.
The diff coverage is 85.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13972      +/-   ##
==========================================
+ Coverage   82.89%   82.94%   +0.05%     
==========================================
  Files         466      469       +3     
  Lines       57728    58343     +615     
==========================================
+ Hits        47854    48394     +540     
- Misses       9874     9949      +75     
Impacted Files Coverage Δ
..._beam/runners/portability/sdk_container_builder.py 40.00% <7.69%> (-3.28%) ⬇️
...nternal/clients/cloudbuild/cloudbuild_v1_client.py 55.17% <55.17%> (ø)
...s/dataflow/internal/clients/cloudbuild/__init__.py 80.00% <80.00%> (ø)
...ernal/clients/cloudbuild/cloudbuild_v1_messages.py 100.00% <100.00%> (ø)
.../python/apache_beam/transforms/periodicsequence.py 96.49% <0.00%> (-1.76%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.29% <0.00%> (-0.53%) ⬇️
...thon/apache_beam/io/aws/clients/s3/boto3_client.py 13.22% <0.00%> (-0.12%) ⬇️
setup.py 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf4555...7929d6f. Read the comment docs.

@TheNeuralBit
Copy link
Member Author

It looks like we may have a forward fix, see BEAM-11805. I'll look into it further and send a new PR tomorrow.

@kennknowles
Copy link
Member

The dependency analysis is saying unusedDeclaredDeps for auto-value-annotations 1.7.2 and 1.7.4 across a few modules. Hrmm.

@TheNeuralBit
Copy link
Member Author

Oh I just reverted the GCP BOM commit and not the AutoValue commit. I guess if we go forward with this we'll need to revert both.

@TheNeuralBit TheNeuralBit changed the title [BEAM-11805] Revert GCP version updates from #13765 [BEAM-11805] Revert version updates from #13765 Feb 12, 2021
@TheNeuralBit
Copy link
Member Author

Run Java PostCommit

@TheNeuralBit
Copy link
Member Author

I think we should send this PR to get CI green. Current breakage affects Java PostCommit as well as all Python PostCommits (The same spanner code is used in Python via xlang).

CC: @allenpradeep if we roll this back you'll need to rollforward with your fix.

@kennknowles
Copy link
Member

Agree. CI green is top priority.

@TheNeuralBit
Copy link
Member Author

Run Java PreCommit

@TheNeuralBit
Copy link
Member Author

PostCommit timed out, but SpannerReadIT did pass: https://ci-beam.apache.org/job/beam_PostCommit_Java_PR/573/testReport/org.apache.beam.sdk.io.gcp.spanner/SpannerReadIT/

I'm going to go ahead and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants