Skip to content

Conversation

@ajamato
Copy link

@ajamato ajamato commented Feb 17, 2021

This reverts commit 625ee1f.

The commit broke ValidateRunnerXlangTest.combineGloballyTest broken in beam_PostCommit_XVR_Direct

See test failure details here:
https://issues.apache.org/jira/browse/BEAM-11822?filter=-2


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@ajamato
Copy link
Author

ajamato commented Feb 17, 2021

R: @robertwb

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure rollback? If so, LGTM.

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #14004 (9c60fd5) into master (8f87957) will decrease coverage by 0.02%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14004      +/-   ##
==========================================
- Coverage   82.94%   82.92%   -0.03%     
==========================================
  Files         469      469              
  Lines       58343    58233     -110     
==========================================
- Hits        48394    48287     -107     
+ Misses       9949     9946       -3     
Impacted Files Coverage Δ
...hon/apache_beam/runners/worker/bundle_processor.py 93.95% <ø> (+0.09%) ⬆️
...eam/runners/portability/fn_api_runner/execution.py 92.03% <42.85%> (-1.65%) ⬇️
...dks/python/apache_beam/runners/pipeline_context.py 92.74% <0.00%> (-0.81%) ⬇️
sdks/python/apache_beam/coders/coder_impl.py 95.38% <0.00%> (-0.14%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.69% <0.00%> (+0.15%) ⬆️
sdks/python/apache_beam/io/iobase.py 84.81% <0.00%> (+0.26%) ⬆️
sdks/python/apache_beam/io/localfilesystem.py 92.42% <0.00%> (+0.75%) ⬆️
sdks/python/apache_beam/internal/metrics/metric.py 87.50% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f87957...9c60fd5. Read the comment docs.

@robertwb robertwb merged commit 871e023 into apache:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants