Skip to content

[BEAM-11747] Disable BeamJavaUdfCalcRule. #14008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ibzib wants to merge 1 commit into from
Closed

[BEAM-11747] Disable BeamJavaUdfCalcRule. #14008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamJavaUdfCalcRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ private BeamJavaUdfCalcRule() {

@Override
public boolean matches(RelOptRuleCall x) {
return ZetaSQLQueryPlanner.hasOnlyJavaUdfInProjects(x);
// TODO(BEAM-11747) Re-enable this rule when we can guarantee its correctness.
return false;
}

@Override
Expand Down
2 changes: 2 additions & 0 deletions .../zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlJavaUdfTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import org.codehaus.commons.compiler.CompileException;
import org.joda.time.Duration;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
Expand All @@ -49,6 +50,7 @@
* beam.sql.udf.test.empty_jar_path</code> must be set.
*/
@RunWith(JUnit4.class)
@Ignore("TODO(BEAM-11747) Re-enable when BeamJavaUdfCalcRule can be re-enabled.")
public class ZetaSqlJavaUdfTest extends ZetaSqlTestBase {
@Rule public transient TestPipeline pipeline = TestPipeline.create();
@Rule public ExpectedException thrown = ExpectedException.none();
Expand Down