Skip to content

[BEAM-11747] Disable BeamJavaUdfCalcRule by default. #14010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibzib merged 2 commits into from
Feb 18, 2021
Merged

[BEAM-11747] Disable BeamJavaUdfCalcRule by default. #14010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d3ffe7
[BEAM-11747] Disable BeamJavaUdfCalcRule by default.
Feb 18, 2021
3dfbaaf
spotless
Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,9 @@
"nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
})
public class ZetaSQLQueryPlanner implements QueryPlanner {
// TODO(BEAM-11747) Re-enable BeamJavaUdfCalcRule by default when it is safe to do so.
public static final Collection<RelOptRule> DEFAULT_CALC =
ImmutableList.<RelOptRule>builder()
.add(BeamZetaSqlCalcRule.INSTANCE)
.add(BeamJavaUdfCalcRule.INSTANCE)
.build();
ImmutableList.<RelOptRule>builder().add(BeamZetaSqlCalcRule.INSTANCE).build();

private static final Logger LOG = LoggerFactory.getLogger(ZetaSQLQueryPlanner.class);

Expand Down
2 changes: 2 additions & 0 deletions .../zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlJavaUdfTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import org.codehaus.commons.compiler.CompileException;
import org.joda.time.Duration;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
Expand All @@ -49,6 +50,7 @@
* beam.sql.udf.test.empty_jar_path</code> must be set.
*/
@RunWith(JUnit4.class)
@Ignore("TODO(BEAM-11747) Re-enable when BeamJavaUdfCalcRule can be re-enabled.")
public class ZetaSqlJavaUdfTest extends ZetaSqlTestBase {
@Rule public transient TestPipeline pipeline = TestPipeline.create();
@Rule public ExpectedException thrown = ExpectedException.none();
Expand Down