-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-10937] Tour of Beam: Reading and writing data notebook #14045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10937] Tour of Beam: Reading and writing data notebook #14045
Conversation
|
Will need to be added to the landing page #13747 as well, whichever merges first. |
|
I glanced at this. It looks good. Some high level comments:
I would like to load balance these reviews across the team. For this one I will nominate @emilymye in addition to @rosetn. Feel free to ping me once this is ready to merge after both reviews. |
…ding-writing-data
|
Got it, I removed the info boxes about the disk speeds. I'm also renaming "Source" to "input transform" and "Sink" to "output transform" since that might be more accurate terms. |
emilymye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will defer to @rosetn for rest of review :)
Co-authored-by: emily <emilyye@google.com>
Co-authored-by: emily <emilyye@google.com>
Co-authored-by: emily <emilyye@google.com>
…avazos/beam into tour-of-beam-reading-writing-data
Co-authored-by: emily <emilyye@google.com>
…avazos/beam into tour-of-beam-reading-writing-data
davidcavazos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments, here's the updated version.
|
Hi @emilymye, can you take a look at this whenever you have a chance? Thank you! |
|
Hi @rosetn, I've addressed your review comments, please let me know what you think. |
rosetn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great, David!
|
Friendly ping @emilymye :) |
|
LGTM! @aaltay will have to actually approve and submit because I don't have committer access. |
|
Thank you! And thank you for the reviews! |
This is the second introductory notebook on how to read and write data.
It covers:
ReadFromTextandWriteToTexttransformsR: @aaltay
R: @rosetn
Staged:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.