Skip to content

[BEAM-10961] enable strict dependency checking for sdks/java/io/kafka #14057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibzib merged 3 commits into from
Feb 24, 2021
Merged

[BEAM-10961] enable strict dependency checking for sdks/java/io/kafka #14057

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6c0317
[BEAM-10961] enable strict dependency checking for sdks/java/io/kafka
shehzaadn-vd Feb 24, 2021
82d173b
[BEAM-10961] (1) fix spacing (2) remove kafka-clients dependency (3) …
shehzaadn-vd Feb 24, 2021
f6bee0b
Trigger Build
shehzaadn-vd Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions sdks/java/io/kafka/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import java.util.stream.Collectors

plugins { id 'org.apache.beam.module' }
applyJavaNature(
enableStrictDependencies: true,
automaticModuleName: 'org.apache.beam.sdk.io.kafka',
mavenRepositories: [
[id: 'io.confluent', url: 'https://packages.confluent.io/maven/']
Expand Down Expand Up @@ -49,6 +50,8 @@ dependencies {
compile library.java.vendored_guava_26_0_jre
compile project(path: ":sdks:java:core", configuration: "shadow")
compile project(":sdks:java:expansion-service")
permitUnusedDeclared project(":sdks:java:expansion-service") // BEAM-11761
compile library.java.avro
// Get back to "provided" since 2.14
provided library.java.kafka_clients
compile library.java.slf4j_api
Expand All @@ -57,6 +60,13 @@ dependencies {
compile library.java.jackson_databind
compile "org.springframework:spring-expression:4.3.18.RELEASE"
compile ("io.confluent:kafka-avro-serializer:5.3.2") {
// zookeeper depends on "spotbugs-annotations:3.1.9" which clashes with current
// "spotbugs-annotations:3.1.12" used in Beam. Not required.
exclude group: "org.apache.zookeeper", module: "zookeeper"
// "kafka-clients" has to be provided since user can use its own version.
exclude group: "org.apache.kafka", module: "kafka-clients"
}
compile ("io.confluent:kafka-schema-registry-client:5.3.2") {
// It depends on "spotbugs-annotations:3.1.9" which clashes with current
// "spotbugs-annotations:3.1.12" used in Beam. Not required.
exclude group: "org.apache.zookeeper", module: "zookeeper"
Expand All @@ -71,8 +81,6 @@ dependencies {
// For testing Cross-language transforms
testCompile project(":runners:core-construction-java")
testCompile library.java.avro
testCompile library.java.hamcrest_core
testCompile library.java.hamcrest_library
testCompile library.java.junit
testCompile library.java.powermock
testCompile library.java.powermock_mockito
Expand Down