Skip to content

[BEAM-10632] Checkerframework nullness cleanups #14107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheNeuralBit merged 1 commit into from
Mar 2, 2021
Merged

[BEAM-10632] Checkerframework nullness cleanups #14107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions sdks/java/expansion-service/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ dependencies {
compile library.java.slf4j_api
runtimeOnly library.java.slf4j_jdk14
testCompile library.java.junit
// TODO(BEAM-10632): Remove this. Currently Schema inference (used in
// ExpansionServiceTest) hits an NPE when checker is enabled and
// checkerframework is not in the classpath.
testCompile "org.checkerframework:checker:3.10.0"
}

task runExpansionService (type: JavaExec) {
Expand Down
2 changes: 1 addition & 1 deletion ...ion-service/src/test/java/org/apache/beam/sdk/expansion/service/ExpansionServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@

import com.google.auto.service.AutoService;
import com.google.auto.value.AutoValue;
import edu.umd.cs.findbugs.annotations.Nullable;
import java.io.IOException;
import java.util.Collections;
import java.util.HashSet;
Expand Down Expand Up @@ -60,6 +59,7 @@
import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList;
import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableMap;
import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables;
import org.checkerframework.checker.nullness.qual.Nullable;
import org.hamcrest.Matchers;
import org.junit.Test;

Expand Down