[BEAM-11913] Add support for Hadoop configuration on ParquetIO #14171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iemejia
commented
Mar 9, 2021
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
Show resolved
Hide resolved
aromanenko-dev
approved these changes
Mar 9, 2021
Contributor
aromanenko-dev
left a comment
aromanenko-dev
left a comment
There was a problem hiding this comment.
Thanks, LGTM in general!
A minor comment and, please, update CHANGES.md and maybe add a simple example on Predicate using into main class Javadoc.
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
Show resolved
Hide resolved
Member
Author
|
For the Filter Predicate use I will add that in a subsequent PR as part of BEAM-11908 where I plan to deprecate I will let you know for the review. Thanks @aromanenko-dev! |
Member
Author
|
CC @JozoVilcek @anantdamle for awareness we decided to enable the full Hadoop Configuration object now. Sorry if this caused some inconvenience in the past. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should expose only Hadoop's Configuration as we do in other IOs. This also helps the Beam API to be compatible with the Parquet APIs. I introduced here a test that uses Parquet to do a filter predicates for example.
R: @aromanenko-dev
CC: @TheNeuralBit for awareness