-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-11277] Add method to check if two TableSchema are equal #14394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
R: @pabloem Looks like I just missed the closing of the last PR :) |
|
ooops - sorry about the surprise. I know of someone else making a PR to the same file, so I wanted to avoid merge issues. |
Codecov Report
@@ Coverage Diff @@
## master #14394 +/- ##
==========================================
- Coverage 83.45% 83.44% -0.02%
==========================================
Files 470 470
Lines 59001 59100 +99
==========================================
+ Hits 49239 49315 +76
- Misses 9762 9785 +23
Continue to review full report at Codecov.
|
|
Thanks, no worries! Busy end of quarter so I haven't had a lot of time to look at this. |
|
|
ff5a091 to
a7990e7
Compare
|
Run Python 3.8 PostCommit |
1 similar comment
|
Run Python 3.8 PostCommit |
|
LGTM thanks @chunyang ! |
A followup to #14113 to improve the schema equality checking.
The check in the previous PR has a high false positive rate for detecting whether a schema update job needs to be run because a schema update job is created even if the field ordering is different.
This PR adds a schema equivalence check with more specificity. Now we can do a field-order insensitive comparison on the schema and only run a schema update job when the fields themselves are different.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.If this contribution is large, please file an Apache Individual Contributor License Agreement.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.