-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-12453]: Add interface to access I/O topic information for a Samza Beam job and PipelineJsonRenderer to create the JSON Beam DAG #14945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kw2542
approved these changes
Jun 4, 2021
Contributor
|
Run Java PreCommit |
kw2542
reviewed
Jun 8, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaRunner.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Jun 8, 2021
...ers/samza/src/test/java/org/apache/beam/runners/samza/renderer/PipelineJsonRendererTest.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Jun 8, 2021
...ers/samza/src/test/java/org/apache/beam/runners/samza/renderer/PipelineJsonRendererTest.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Jun 8, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Jun 8, 2021
...ers/samza/src/test/java/org/apache/beam/runners/samza/renderer/PipelineJsonRendererTest.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Jun 8, 2021
kw2542
reviewed
Jun 15, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
Contributor
|
Please fix the compilation error as well: |
Member
|
What is the next step on this PR? |
kw2542
reviewed
Aug 5, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaRunner.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Aug 5, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Aug 5, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Aug 5, 2021
kw2542
reviewed
Aug 5, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Aug 5, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Aug 5, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Aug 9, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Aug 9, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
kw2542
reviewed
Aug 9, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaRunner.java
Outdated
Show resolved
Hide resolved
kw2542
approved these changes
Aug 10, 2021
Contributor
kw2542
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xinyuiscool
reviewed
Aug 10, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaIOInfo.java
Outdated
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaRunner.java
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Outdated
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaIOInfo.java
Outdated
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/renderer/PipelineJsonRenderer.java
Show resolved
Hide resolved
xinyuiscool
approved these changes
Aug 12, 2021
Contributor
xinyuiscool
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the enhancements.
PawasChhokra
added a commit
to PawasChhokra/beam
that referenced
this pull request
Aug 27, 2021
…za Beam job and PipelineJsonRenderer to create the JSON Beam DAG (apache#14945)
4 tasks
dxichen
pushed a commit
to linkedin/beam
that referenced
this pull request
Aug 27, 2021
* [BEAM-12453]: Add interface to access I/O topic information for a Samza Beam job and PipelineJsonRenderer to create the JSON Beam DAG (apache#14945) * [BEAM-12757]: Remove call for Json Dag in Portable PipelineRunner as it's not supported yet (apache#15332) * [BEAM-12772] Remove test implementation of SamzaIORegistrar (apache#15347) * Increment project.version to 2.28.0.6
4 tasks
dxichen
pushed a commit
to linkedin/beam
that referenced
this pull request
Sep 22, 2021
…za Beam job and PipelineJsonRenderer to create the JSON Beam DAG (apache#14945) RB=2752723 G=samza-reviewers R=xiliu,kwu A=xiliu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features:
Uses:
These changes can be used in the visualization of the Beam pipeline.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.