Skip to content

Conversation

@benEng
Copy link
Contributor

@benEng benEng commented Jul 29, 2021

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #15245 (42b77ea) into master (faac725) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15245      +/-   ##
==========================================
+ Coverage   83.80%   83.82%   +0.01%     
==========================================
  Files         441      440       -1     
  Lines       59764    59767       +3     
==========================================
+ Hits        50084    50097      +13     
+ Misses       9680     9670      -10     
Impacted Files Coverage Δ
sdks/python/apache_beam/testing/test_pipeline.py 98.24% <ø> (ø)
sdks/python/apache_beam/io/fileio.py 96.00% <100.00%> (+0.11%) ⬆️
...apache_beam/runners/dataflow/internal/apiclient.py 74.66% <100.00%> (ø)
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.85% <0.00%> (-0.16%) ⬇️
setup.py 0.00% <0.00%> (ø)
test_config.py
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (+0.24%) ⬆️
...ks/python/apache_beam/runners/worker/data_plane.py 92.42% <0.00%> (+1.81%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 90.24% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb4afe...42b77ea. Read the comment docs.

@benEng
Copy link
Contributor Author

benEng commented Jul 29, 2021

Run Java_Examples_Dataflow_Java11 PreCommit

@benEng
Copy link
Contributor Author

benEng commented Jul 29, 2021

Run Python Dataflow ValidatesContainer

@benEng
Copy link
Contributor Author

benEng commented Jul 29, 2021

Run Python Dataflow ValidatesRunner

@benEng
Copy link
Contributor Author

benEng commented Jul 29, 2021

Run Python Dataflow V2 ValidatesRunner

@benEng
Copy link
Contributor Author

benEng commented Jul 29, 2021

Run XVR_Dataflow PostCommit

@benEng
Copy link
Contributor Author

benEng commented Jul 29, 2021

Run Python37 WordCountIT Performance Test

@benEng
Copy link
Contributor Author

benEng commented Jul 30, 2021

Run Java_Examples_Dataflow_Java11 PreCommit

@benEng
Copy link
Contributor Author

benEng commented Jul 30, 2021

Run Java_Examples_Dataflow PreCommit

@benEng
Copy link
Contributor Author

benEng commented Jul 30, 2021

Run Python PreCommit

@benEng benEng changed the title [WIP][BEAM-3713] Cleanup, remove nosetest references [BEAM-3713] Cleanup, remove nosetest references Aug 3, 2021
@benEng benEng marked this pull request as ready for review August 3, 2021 23:41
@benEng
Copy link
Contributor Author

benEng commented Aug 3, 2021

R: @udim
Hi Udi, I made the cleanup in this PR. Some checks are falling, but those are failing on cron jobs too. I think aren't related to these changes.
Could you help me to review this?

@udim
Copy link
Member

udim commented Aug 5, 2021

Run Java_Examples_Dataflow PreCommit

@udim
Copy link
Member

udim commented Aug 5, 2021

Run Python PreCommit

Copy link
Member

@udim udim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One comment

@benEng
Copy link
Contributor Author

benEng commented Aug 5, 2021

Run SQL PreCommit

@udim
Copy link
Member

udim commented Aug 7, 2021

The Java failures are irrelevant to this PR, but the Python precommit is perma-red: https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/buildTimeTrend

Since this PR may introduce new failures, we need to wait until Python precommit is green before merging.

@udim
Copy link
Member

udim commented Aug 12, 2021

run python precommit

@udim
Copy link
Member

udim commented Aug 16, 2021

run python precommit

@kileys
Copy link
Contributor

kileys commented Aug 16, 2021

Run Java_Examples_Dataflow_Java11 PreCommit

@kileys
Copy link
Contributor

kileys commented Aug 16, 2021

Run Java_Examples_Dataflow PreCommit

@benEng
Copy link
Contributor Author

benEng commented Aug 17, 2021

run python precommit

@udim udim merged commit 9188bbf into apache:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants