-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-3713] Cleanup, remove nosetest references #15245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15245 +/- ##
==========================================
+ Coverage 83.80% 83.82% +0.01%
==========================================
Files 441 440 -1
Lines 59764 59767 +3
==========================================
+ Hits 50084 50097 +13
+ Misses 9680 9670 -10
Continue to review full report at Codecov.
|
|
Run Java_Examples_Dataflow_Java11 PreCommit |
|
Run Python Dataflow ValidatesContainer |
|
Run Python Dataflow ValidatesRunner |
|
Run Python Dataflow V2 ValidatesRunner |
|
Run XVR_Dataflow PostCommit |
|
Run Python37 WordCountIT Performance Test |
|
Run Java_Examples_Dataflow_Java11 PreCommit |
|
Run Java_Examples_Dataflow PreCommit |
|
Run Python PreCommit |
|
R: @udim |
|
Run Java_Examples_Dataflow PreCommit |
|
Run Python PreCommit |
udim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One comment
|
Run SQL PreCommit |
|
The Java failures are irrelevant to this PR, but the Python precommit is perma-red: https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/buildTimeTrend Since this PR may introduce new failures, we need to wait until Python precommit is green before merging. |
|
run python precommit |
|
run python precommit |
|
Run Java_Examples_Dataflow_Java11 PreCommit |
|
Run Java_Examples_Dataflow PreCommit |
|
run python precommit |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.