Skip to content

Conversation

@jbrr
Copy link
Contributor

@jbrr jbrr commented Aug 1, 2021

While trying to wrap my head around what exactly an SDF is, I noticed that the package name containing RestrictionProvider was incorrect in a couple places.

@aaltay
@charlesccychen


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #15259 (3974b13) into master (dce846b) will increase coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15259      +/-   ##
==========================================
+ Coverage   83.84%   84.09%   +0.24%     
==========================================
  Files         441      441              
  Lines       59724    61552    +1828     
==========================================
+ Hits        50077    51761    +1684     
- Misses       9647     9791     +144     
Impacted Files Coverage Δ
...s/python/apache_beam/examples/snippets/snippets.py 76.70% <0.00%> (ø)
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (-2.24%) ⬇️
sdks/python/apache_beam/io/gcp/bigquery_tools.py 87.41% <0.00%> (-0.02%) ⬇️
sdks/python/apache_beam/io/filebasedsource.py 98.73% <0.00%> (-0.02%) ⬇️
...ython/apache_beam/examples/kafkataxi/kafka_taxi.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/transforms/ptransform.py 93.63% <0.00%> (+0.08%) ⬆️
...s/python/apache_beam/io/gcp/bigquery_file_loads.py 87.58% <0.00%> (+0.08%) ⬆️
sdks/python/apache_beam/io/textio.py 97.32% <0.00%> (+0.24%) ⬆️
...apache_beam/runners/dataflow/internal/apiclient.py 75.31% <0.00%> (+0.64%) ⬆️
sdks/python/apache_beam/io/fileio.py 96.64% <0.00%> (+0.74%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce846b...3974b13. Read the comment docs.

@lukecwik
Copy link
Member

lukecwik commented Aug 9, 2021

Run Python PreCommit

@lukecwik
Copy link
Member

lukecwik commented Aug 9, 2021

Run PythonFormatter PreCommit

@lukecwik
Copy link
Member

lukecwik commented Aug 9, 2021

Run PythonLint PreCommit

@lukecwik
Copy link
Member

lukecwik commented Aug 9, 2021

Run Python_PVR_Flink PreCommit

@lukecwik
Copy link
Member

lukecwik commented Aug 9, 2021

13:41:13 Running pylint...
13:42:20 ************* Module apache_beam.examples.snippets.snippets
13:42:20 apache_beam/examples/snippets/snippets.py:1650:0: C0301: Line too long (81/80) (line-too-long)
13:42:20 apache_beam/examples/snippets/snippets.py:1683:0: C0301: Line too long (81/80) (line-too-long)

@lukecwik
Copy link
Member

lukecwik commented Aug 9, 2021

Run Python PreCommit

@lukecwik
Copy link
Member

R: @lukecwik

@pabloem pabloem requested a review from lukecwik August 12, 2021 17:39
@lukecwik
Copy link
Member

@pabloem I'm waiting till BEAM-12699 so I can the test can pass.

@lukecwik
Copy link
Member

Run Python PreCommit

3 similar comments
@lukecwik
Copy link
Member

Run Python PreCommit

@lukecwik
Copy link
Member

Run Python PreCommit

@lukecwik
Copy link
Member

Run Python PreCommit

@lukecwik
Copy link
Member

Ignoring codecov/patch result

@lukecwik lukecwik merged commit 0a1ade1 into apache:master Aug 17, 2021
@jbrr jbrr deleted the fix-python-sdf-example branch September 2, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants