-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Minor correction in SDF Python examples #15259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15259 +/- ##
==========================================
+ Coverage 83.84% 84.09% +0.24%
==========================================
Files 441 441
Lines 59724 61552 +1828
==========================================
+ Hits 50077 51761 +1684
- Misses 9647 9791 +144
Continue to review full report at Codecov.
|
|
Run Python PreCommit |
|
Run PythonFormatter PreCommit |
|
Run PythonLint PreCommit |
|
Run Python_PVR_Flink PreCommit |
|
|
Run Python PreCommit |
|
R: @lukecwik |
|
@pabloem I'm waiting till BEAM-12699 so I can the test can pass. |
|
Run Python PreCommit |
3 similar comments
|
Run Python PreCommit |
|
Run Python PreCommit |
|
Run Python PreCommit |
|
Ignoring codecov/patch result |
While trying to wrap my head around what exactly an SDF is, I noticed that the package name containing
RestrictionProviderwas incorrect in a couple places.@aaltay
@charlesccychen
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.