Skip to content

Conversation

@crcornwell
Copy link

@crcornwell crcornwell commented Aug 4, 2021

When writing temp tables during BigQuery batch loads, schema update options are invalid since the write disposition is always hard coded to WRITE_TRUNCATE. Including schema update options like this causes the load jobs to fail with the error:

"Schema update options should only be specified with WRITE_APPEND disposition, or with WRITE_TRUNCATE disposition on a table partition."

We could also address this by overriding the schema update options value for temp tables in the processElement function, similar to how its currently overriding the create and write dispositions. Let me know if that's preferred, or if I've totally missed the mark here otherwise.

R: @lukecwik
R: @chamikaramj

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

when writing temp tables during BigQuery batch loads, schema update options are invalid
@lukecwik
Copy link
Member

Run Java PreCommit

@lukecwik
Copy link
Member

Run Java_Examples_Dataflow PreCommit

@lukecwik
Copy link
Member

Run Java_Examples_Dataflow_Java11 PreCommit

@chamikaramj
Copy link
Contributor

I don't think SchemaUpdateOptions can be just dropped.

See the corresponding fix to the Python side here: #14113

Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crcornwell
Copy link
Author

Ohh I see, so even though this small change would allow the temporary tables to be created, the copy job would still fail due to the schemas mismatching,

Okay, this is a bit chunkier than I anticipated, but I'll try to find some time to work on it.

@kennknowles
Copy link
Member

Ah, I just came across this. Any update?

@kennknowles kennknowles changed the title [BEAM-12725] Pass null for schemaUpdateOptions [BEAM-12482] Pass null for schemaUpdateOptions Aug 18, 2021
@aaltay
Copy link
Member

aaltay commented Sep 3, 2021

What is the next step on this PR?

@crcornwell - are you still planning to work on it? Should we close it?

@crcornwell
Copy link
Author

Yeah I'll go ahead and close it.

@crcornwell crcornwell closed this Sep 7, 2021
@crcornwell crcornwell deleted the BEAM-12725 branch September 7, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants