Skip to content

Conversation

@benEng
Copy link
Contributor

@benEng benEng commented Aug 5, 2021

…oreLegacy flaky test

Enabling flaky test.
Possible fix in FLINK-23201 for new minor releases.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@benEng
Copy link
Contributor Author

benEng commented Aug 5, 2021

Run Java PreCommit

4 similar comments
@benEng
Copy link
Contributor Author

benEng commented Aug 5, 2021

Run Java PreCommit

@benEng
Copy link
Contributor Author

benEng commented Aug 5, 2021

Run Java PreCommit

@benEng
Copy link
Contributor Author

benEng commented Aug 5, 2021

Run Java PreCommit

@benEng
Copy link
Contributor Author

benEng commented Aug 6, 2021

Run Java PreCommit

@benEng benEng changed the title [WIP][BEAM-10955] Update Flink minor versions and enable testSavepointRest… [BEAM-10955] Update Flink minor versions and enable testSavepointRest… Aug 6, 2021
@benEng benEng marked this pull request as ready for review August 6, 2021 00:33
@benEng
Copy link
Contributor Author

benEng commented Aug 6, 2021

R: @ibzib. Could you help me to review this?

@ibzib
Copy link

ibzib commented Aug 11, 2021

Run Python_PVR_Flink PreCommit

@ibzib
Copy link

ibzib commented Aug 11, 2021

Run Java Flink PortableValidatesRunner Batch

@ibzib
Copy link

ibzib commented Aug 11, 2021

Run Java Flink PortableValidatesRunner Streaming

@ibzib
Copy link

ibzib commented Aug 11, 2021

Run Flink ValidatesRunner

@kileys
Copy link
Contributor

kileys commented Aug 16, 2021

What's the effort required to split out the test? It looks like the next release will be ~October plus however long to update the Flink versions in Beam

@kileys
Copy link
Contributor

kileys commented Aug 16, 2021

@ibzib How important is this test? Is it okay to wait 3+ months to reenable?

@ibzib
Copy link

ibzib commented Aug 16, 2021

What's the effort required to split out the test? It looks like the next release will be ~October plus however long to update the Flink versions in Beam

I realized we don't even need to split the test into a different file, we can just make the execution of the test conditional on the Flink version being used. I added a commit to this PR.

@ibzib
Copy link

ibzib commented Aug 16, 2021

@benWize can you please also add a notice to CHANGES.md that we've upgraded the Flink versions?

@kileys
Copy link
Contributor

kileys commented Aug 16, 2021

I realized we don't even need to split the test into a different file, we can just make the execution of the test conditional on the Flink version being used. I added a commit to this PR.

Thanks Kyle!

@benEng
Copy link
Contributor Author

benEng commented Aug 16, 2021

@benWize can you please also add a notice to CHANGES.md that we've upgraded the Flink versions?

Yes, done!

…oreLegacy flaky test

[BEAM-10955] Fix spotlessApply

[BEAM-10955] Add a notice to CHANGES.md of upgraded Flink versions

[BEAM-10955] Only run legacy savepoint test on Flink >1.12.
@ibzib
Copy link

ibzib commented Aug 17, 2021

Huh, the Java precommit flake is kind of suspicious since it's Flink related. Looks like we've seen it before though: BEAM-12291

@ibzib
Copy link

ibzib commented Aug 17, 2021

run java precommit

@ibzib ibzib merged commit 50efad6 into apache:master Aug 17, 2021
@benEng
Copy link
Contributor Author

benEng commented Aug 17, 2021

Thanks Kyle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants