-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-10955] Update Flink minor versions and enable testSavepointRest… #15290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Run Java PreCommit |
4 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
R: @ibzib. Could you help me to review this? |
runners/flink/src/test/java/org/apache/beam/runners/flink/FlinkSavepointTest.java
Outdated
Show resolved
Hide resolved
|
Run Python_PVR_Flink PreCommit |
|
Run Java Flink PortableValidatesRunner Batch |
|
Run Java Flink PortableValidatesRunner Streaming |
|
Run Flink ValidatesRunner |
|
What's the effort required to split out the test? It looks like the next release will be ~October plus however long to update the Flink versions in Beam |
|
@ibzib How important is this test? Is it okay to wait 3+ months to reenable? |
I realized we don't even need to split the test into a different file, we can just make the execution of the test conditional on the Flink version being used. I added a commit to this PR. |
|
@benWize can you please also add a notice to CHANGES.md that we've upgraded the Flink versions? |
Thanks Kyle! |
Yes, done! |
…oreLegacy flaky test [BEAM-10955] Fix spotlessApply [BEAM-10955] Add a notice to CHANGES.md of upgraded Flink versions [BEAM-10955] Only run legacy savepoint test on Flink >1.12.
|
Huh, the Java precommit flake is kind of suspicious since it's Flink related. Looks like we've seen it before though: BEAM-12291 |
|
run java precommit |
|
Thanks Kyle! |
…oreLegacy flaky test
Enabling flaky test.
Possible fix in FLINK-23201 for new minor releases.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.