Skip to content

Conversation

@jrmccluskey
Copy link
Contributor

Adds an AddElementList() function to the TestStream config object, allowing users to add slices/arrays to the stream object at once. Also fleshes out the integration test suite for TestStream to test multiple input types (int64, float 64, bool) and adds comments indicating that these are the three currently supported types.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@jrmccluskey
Copy link
Contributor Author

Run Go PostCommit

@jrmccluskey
Copy link
Contributor Author

Run Go Flink ValidatesRunner

@jrmccluskey
Copy link
Contributor Author

R: @lostluck

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lostluck
Copy link
Contributor

It appears that we've finally overloaded our little jenkins server with running all the integration tests packages simultaneously. I have PR #15321 to constrain that a bit, and once merged, we'll re run and see if that fixes it.

@lostluck
Copy link
Contributor

Run Go Flink ValidatesRunner

@lostluck
Copy link
Contributor

Run Go PostCommit

Co-authored-by: Robert Burke <lostluck@users.noreply.github.com>
@jrmccluskey
Copy link
Contributor Author

Run Go PostCommit

@jrmccluskey
Copy link
Contributor Author

Run Go Flink ValidatesRunner

@jrmccluskey
Copy link
Contributor Author

Run Go Flink ValidatesRunner

@jrmccluskey
Copy link
Contributor Author

Run Go PostCommit

@jrmccluskey
Copy link
Contributor Author

Run Go Flink ValidatesRunner

@jrmccluskey
Copy link
Contributor Author

Run Go PostCommit

@jrmccluskey
Copy link
Contributor Author

Run Go Flink ValidatesRunner

@jrmccluskey
Copy link
Contributor Author

Run Go Flink ValidatesRunner

@jrmccluskey
Copy link
Contributor Author

Run Go PostCommit

@lostluck
Copy link
Contributor

Well that one's weird. It can't find the Go SDK container? don't know why that's happening. AFAICT it built it, but it's not being found by Flink... Hmmm.

@jrmccluskey
Copy link
Contributor Author

Run Go PostCommit

@jrmccluskey
Copy link
Contributor Author

Run Go Flink ValidatesRunner

@lostluck
Copy link
Contributor

I'm going to merge this in, understanding that the new tests aren't enabled right now. Easier to investigate then too. Thanks!

@lostluck lostluck merged commit 80da0ec into apache:master Aug 17, 2021
@jrmccluskey jrmccluskey deleted the teststream branch August 17, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants