Skip to content

[BEAM-12772] Remove test implementation of SamzaIORegistrar (Samza) #15347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xinyuiscool merged 1 commit into from
Aug 18, 2021
Merged

[BEAM-12772] Remove test implementation of SamzaIORegistrar (Samza) #15347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions runners/samza/src/test/java/org/apache/beam/runners/samza/util/PipelineJsonRendererTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,15 @@

import static org.junit.Assert.assertEquals;

import com.google.auto.service.AutoService;
import com.google.gson.JsonParser;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Paths;
import java.util.Optional;
import org.apache.beam.runners.samza.SamzaPipelineOptions;
import org.apache.beam.runners.samza.SamzaRunner;
import org.apache.beam.sdk.Pipeline;
import org.apache.beam.sdk.options.PipelineOptionsFactory;
import org.apache.beam.sdk.runners.TransformHierarchy;
import org.apache.beam.sdk.transforms.Create;
import org.apache.beam.sdk.transforms.Sum;
import org.apache.beam.sdk.transforms.windowing.FixedWindows;
Expand All @@ -54,7 +51,6 @@ public void testEmptyPipeline() {
String jsonDag =
"{ \"RootNode\": ["
+ " { \"fullName\":\"OuterMostNode\","
+ " \"ioInfo\":\"TestTopic\","
+ " \"ChildNodes\":[ ]}],\"graphLinks\": []"
+ "}";

Expand Down Expand Up @@ -85,21 +81,4 @@ public void testCompositePipeline() throws IOException {
JsonParser.parseString(
PipelineJsonRenderer.toJsonString(p).replaceAll(System.lineSeparator(), "")));
}

@AutoService(PipelineJsonRenderer.SamzaIORegistrar.class)
public static class Registrar implements PipelineJsonRenderer.SamzaIORegistrar {

@Override
public PipelineJsonRenderer.SamzaIOInfo getSamzaIO() {
return new PipelineJsonRenderer.SamzaIOInfo() {
@Override
public Optional<String> getIOInfo(TransformHierarchy.Node node) {
if (node.isRootNode()) {
return Optional.of("TestTopic");
}
return Optional.empty();
}
};
}
}
}
1 change: 0 additions & 1 deletion runners/samza/src/test/resources/ExpectedDag.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"RootNode": [
{ "fullName":"OuterMostNode",
"ioInfo":"TestTopic",
"ChildNodes":[
{ "fullName":"Create.TimestampedValues",
"enclosingNode":"OuterMostNode",
Expand Down