[BEAM-5097] Increment counter for "small words" in go SDK example #15399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riteshghorse
changed the title
Contributor
Author
|
R: @lostluck |
Contributor
Author
|
Run Go PostCommit |
lostluck
approved these changes
Aug 30, 2021
Contributor
lostluck
left a comment
lostluck
left a comment
There was a problem hiding this comment.
Approved after the small changes are made. Thanks for your patience!
|
|
||
| func (f *extractFn) ProcessElement(row WordRow, emit func(string, string)) { | ||
| func (f *extractFn) ProcessElement(ctx context.Context, row WordRow, emit func(string, string)) { | ||
|
|
| lineLen = beam.NewDistribution("extract", "lineLenDistro") | ||
| wordRE = regexp.MustCompile(`[a-zA-Z]+('[a-z])?`) | ||
| empty = beam.NewCounter("extract", "emptyLines") | ||
| minLength = flag.Int("min_length", 9, "Minimum word length") |
Contributor
There was a problem hiding this comment.
Since this is a new flag, and this example doesn't filter words, we might want to just call it "small_word_length" instead, and clarify that it determines what gets counted.
Contributor
Author
|
Run Go PostCommit |
lostluck
reviewed
Sep 7, 2021
| for _, word := range wordRE.FindAllString(line, -1) { | ||
| // increment the counter for small words if length of words is | ||
| // less than small_word_length | ||
| if len(word) < *small_word_length { |
Contributor
There was a problem hiding this comment.
Flags aren't available on workers. They'd only have their default values. extractFn needs to change to a structural DoFn (like it is in the other example being updated) so the flag functions properly.
lostluck
approved these changes
Sep 10, 2021
Contributor
lostluck
left a comment
lostluck
left a comment
There was a problem hiding this comment.
LGTM I'll merge this. Thanks!
riteshghorse
deleted the
BEAM-5097-add-counter-to-combine-example-in-go-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added counter to Go SDK examples for small words.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.