-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Added type annotations to some combiners missing it. #15414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These just correspond to the typing annotations of functions called in `extend`, so this shouldn't change the type check behavior.
|
R: @robertwb |
These just correspond to the typing annotations of functions called in `extend`, so this shouldn't change the type check behavior.
Codecov Report
@@ Coverage Diff @@
## master #15414 +/- ##
==========================================
- Coverage 83.83% 83.75% -0.09%
==========================================
Files 440 443 +3
Lines 59886 60099 +213
==========================================
+ Hits 50207 50336 +129
- Misses 9679 9763 +84
Continue to review full report at Codecov.
|
|
note there's one little formatting error: https://ci-beam.apache.org/job/beam_PreCommit_PythonFormatter_Commit/7939/console |
|
Can you fix the yapf errors? |
Done. |
These just correspond to the typing annotations of functions called in
extend, so this shouldn't change the type check behavior.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.