Skip to content

Conversation

@dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Aug 27, 2021

These just correspond to the typing annotations of functions called in extend, so this shouldn't change the type check behavior.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

These just correspond to the typing annotations of functions called in `extend`, so this shouldn't change the type check behavior.
@dmkozh
Copy link
Contributor Author

dmkozh commented Aug 27, 2021

R: @robertwb

dmkozh added 2 commits August 27, 2021 19:44
These just correspond to the typing annotations of functions called in `extend`, so this shouldn't change the type check behavior.
@codecov
Copy link

codecov bot commented Aug 28, 2021

Codecov Report

Merging #15414 (d209b71) into master (cbb363f) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15414      +/-   ##
==========================================
- Coverage   83.83%   83.75%   -0.09%     
==========================================
  Files         440      443       +3     
  Lines       59886    60099     +213     
==========================================
+ Hits        50207    50336     +129     
- Misses       9679     9763      +84     
Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/combiners.py 93.77% <100.00%> (+0.06%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 92.68% <0.00%> (-2.44%) ⬇️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (-2.24%) ⬇️
...ks/python/apache_beam/runners/worker/data_plane.py 87.70% <0.00%> (-1.68%) ⬇️
.../python/apache_beam/transforms/periodicsequence.py 96.72% <0.00%> (-1.64%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.47% <0.00%> (-1.39%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.25% <0.00%> (-0.54%) ⬇️
...apache_beam/runners/dataflow/internal/apiclient.py 76.46% <0.00%> (-0.34%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (-0.25%) ⬇️
setup.py 0.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb363f...d209b71. Read the comment docs.

@pabloem
Copy link
Member

pabloem commented Sep 10, 2021

note there's one little formatting error: https://ci-beam.apache.org/job/beam_PreCommit_PythonFormatter_Commit/7939/console

@pabloem pabloem requested a review from udim September 10, 2021 00:09
@robertwb
Copy link
Contributor

Can you fix the yapf errors?

19:46:42 py3-yapf-check run-test: commands[1] | time yapf --diff --parallel --recursive apache_beam
19:47:09 --- apache_beam/transforms/combiners.py	(original)
19:47:09 +++ apache_beam/transforms/combiners.py	(reformatted)
19:47:09 @@ -700,6 +700,7 @@
19:47:09          a in zip(self._combiners, accumulator)
19:47:09      ]
19:47:09  
19:47:09 +
19:47:09  @with_input_types(T)

@dmkozh
Copy link
Contributor Author

dmkozh commented Sep 10, 2021

Can you fix the yapf errors?

19:46:42 py3-yapf-check run-test: commands[1] | time yapf --diff --parallel --recursive apache_beam
19:47:09 --- apache_beam/transforms/combiners.py	(original)
19:47:09 +++ apache_beam/transforms/combiners.py	(reformatted)
19:47:09 @@ -700,6 +700,7 @@
19:47:09          a in zip(self._combiners, accumulator)
19:47:09      ]
19:47:09  
19:47:09 +
19:47:09  @with_input_types(T)

Done.

@pabloem pabloem merged commit 95c3811 into apache:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants