[BEAM-8376] Google Cloud Firestore Connector - Add handling for partitions queries with zero cursors #15425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danthev
approved these changes
Sep 7, 2021
chamikaramj
reviewed
Sep 9, 2021
...io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreV1.java
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM other than the nit. |
BenWhitehead
force-pushed
the
partition-zero-cursors
branch
from
7e4800b to
0108acd
Compare
Contributor
Author
|
I've added the return statement and squashed everything and this is ready to merge when you have a chance @chamikaramj |
Contributor
Author
|
Run Java_Examples_Dataflow PreCommit |
Contributor
Author
|
Run Java_Examples_Dataflow_Java11 PreCommit |
…tions queries with zero cursors Firestore PartitionQueryResponses can have zero cursors if there are not enough documents to cause a partition cursor to be recorded. Update `PartitionQueryResponseToRunQueryRequest` to emit the provided StructuredQuery without modification if there aren't any cursors.
BenWhitehead
force-pushed
the
partition-zero-cursors
branch
from
0108acd to
8b57eb0
Compare
Contributor
Author
|
Rebased on master and all pre-commits are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firestore PartitionQueryResponses can have zero cursors if there are
not enough documents to cause a partition cursor to be recorded. Update
PartitionQueryResponseToRunQueryRequestto emit the providedStructuredQuery without modification if there aren't any cursors.
Reviewers
R: @chamikaramj
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.