-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-12634] JmsIO auto scaling feature #15464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
73b4442
[BEAM-12634]: Provide generic Autoscaler interface,
rvballada ed03a74
[BEAM-12634]: Add Unit Tests for DefaultAutoScaler and mock custom Au…
rvballada 1ff1855
[BEAM-12634] => Apply suggestions from code review
rvballada a0e9339
[BEAM-12634]: Fix tests and some JavaDoc comments consecutively to co…
rvballada 8117b19
[BEAM-12634]: Add comment on Autoscaler#getTotalBacklogBytes
rvballada 6251c86
Update sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/Auto…
lukecwik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/AutoScaler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.sdk.io.jms; | ||
|
|
||
| import java.io.Serializable; | ||
| import org.apache.beam.sdk.io.UnboundedSource; | ||
|
|
||
| /** | ||
| * Enables users to specify their own `JMS` backlog reporters enabling {@link JmsIO} to report | ||
| * {@link UnboundedSource.UnboundedReader#getTotalBacklogBytes()}. | ||
| */ | ||
| public interface AutoScaler extends Serializable { | ||
|
|
||
| /** The {@link AutoScaler} is started when the {@link JmsIO.UnboundedJmsReader} is started. */ | ||
| void start(); | ||
|
|
||
| /** | ||
| * Returns the size of the backlog of unread data in the underlying data source represented by all | ||
| * splits of this source. | ||
| */ | ||
| long getTotalBacklogBytes(); | ||
rvballada marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /** The {@link AutoScaler} is stopped when the {@link JmsIO.UnboundedJmsReader} is closed. */ | ||
| void stop(); | ||
rvballada marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
37 changes: 37 additions & 0 deletions
37
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/DefaultAutoscaler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.sdk.io.jms; | ||
|
|
||
| import static org.apache.beam.sdk.io.UnboundedSource.UnboundedReader.BACKLOG_UNKNOWN; | ||
|
|
||
| /** | ||
| * Default implementation of {@link AutoScaler}. Returns {@link | ||
| * org.apache.beam.sdk.io.UnboundedSource.UnboundedReader#BACKLOG_UNKNOWN} as the default value. | ||
| */ | ||
| public class DefaultAutoscaler implements AutoScaler { | ||
| @Override | ||
| public void start() {} | ||
|
|
||
| @Override | ||
| public long getTotalBacklogBytes() { | ||
| return BACKLOG_UNKNOWN; | ||
| } | ||
|
|
||
| @Override | ||
| public void stop() {} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.