Skip to content

Conversation

@robertwb
Copy link
Contributor

@robertwb robertwb commented Sep 7, 2021

R: @kileys
CC: @katsiapis


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@lukecwik
Copy link
Member

lukecwik commented Sep 7, 2021

LGTM but some of the tests seemed to have strict name matching:
NameError: name '_CoGroupByKey__CoGBKImpl' is not defined

@lukecwik
Copy link
Member

lukecwik commented Sep 7, 2021

R: @lukecwik

@robertwb
Copy link
Contributor Author

robertwb commented Sep 9, 2021

Thanks. That turned out to be a typo with the double underscore. I'll make sure tests are green before merging.

@robertwb
Copy link
Contributor Author

robertwb commented Sep 9, 2021

I'm getting failures in apache_beam.io.gcp.experimental.spannerio_test.SpannerReadTest.test_read_with_transaction. Commented in JIRA.

@robertwb
Copy link
Contributor Author

robertwb commented Sep 9, 2021

Run Python PreCommit

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #15471 (90ec784) into master (823ab5a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15471   +/-   ##
=======================================
  Coverage   83.74%   83.75%           
=======================================
  Files         443      443           
  Lines       60077    60089   +12     
=======================================
+ Hits        50312    50326   +14     
+ Misses       9765     9763    -2     
Impacted Files Coverage Δ
sdks/python/apache_beam/pipeline.py 91.66% <ø> (ø)
sdks/python/apache_beam/coders/coders.py 88.58% <100.00%> (+0.59%) ⬆️
sdks/python/apache_beam/coders/row_coder.py 95.03% <100.00%> (ø)
sdks/python/apache_beam/coders/typecoders.py 94.52% <100.00%> (+0.07%) ⬆️
...ython/apache_beam/io/gcp/experimental/spannerio.py 88.20% <100.00%> (ø)
sdks/python/apache_beam/transforms/util.py 95.81% <100.00%> (ø)
sdks/python/apache_beam/utils/interactive_utils.py 87.80% <0.00%> (-7.32%) ⬇️
...he_beam/runners/interactive/sql/beam_sql_magics.py 54.70% <0.00%> (-0.96%) ⬇️
...eam/runners/interactive/interactive_environment.py 90.70% <0.00%> (-0.38%) ⬇️
.../python/apache_beam/portability/api/metrics_pb2.py 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15abcf3...90ec784. Read the comment docs.

@lukecwik lukecwik merged commit 7c8503e into apache:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants