Skip to content

[BEAM-12805] Fix XLang CombinePerKey test by explicitly assigning the… #15496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ihji merged 1 commit into from
Sep 10, 2021
Merged

[BEAM-12805] Fix XLang CombinePerKey test by explicitly assigning the… #15496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions sdks/python/apache_beam/runners/portability/expansion_service_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,12 @@ def from_runner_api_parameter(
@ptransform.PTransform.register_urn(TEST_COMPK_URN, None)
class CombinePerKeyTransform(ptransform.PTransform):
def expand(self, pcoll):
return pcoll \
| beam.CombinePerKey(sum).with_output_types(
typing.Tuple[str, int])
output = pcoll \
| beam.CombinePerKey(sum)
# TODO: Use `with_output_types` instead of explicitly
# assigning to `.element_type` after fixing BEAM-12872
output.element_type = beam.typehints.Tuple[str, int]
return output

def to_runner_api_parameter(self, unused_context):
return TEST_COMPK_URN, None
Expand Down