Skip to content

Conversation

@suztomo
Copy link
Contributor

@suztomo suztomo commented Sep 10, 2021

The field must be null when we don't specify the value, rather than an empty value.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@suztomo
Copy link
Contributor Author

suztomo commented Sep 10, 2021

Run Java Postcommit

@suztomo
Copy link
Contributor Author

suztomo commented Sep 10, 2021

Java SDK Post Commit Tests succeeded.

@suztomo
Copy link
Contributor Author

suztomo commented Sep 10, 2021

R: @kennknowles

@suztomo suztomo requested a review from kennknowles September 10, 2021 23:30
@suztomo suztomo changed the title [BEAM-12873] HL7v2IO: to leave schematizedData null, not empty [BEAM-12873] GCP HL7v2IO: to leave schematizedData null, not empty Sep 11, 2021
@suztomo suztomo requested a review from aaltay September 13, 2021 17:24
@suztomo
Copy link
Contributor Author

suztomo commented Sep 13, 2021

R: @aaltay

@aaltay aaltay merged commit c4581cc into master Sep 13, 2021
@aaltay aaltay deleted the BEAM-12873 branch September 13, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants