[BEAM-13064] [Playground] Implement search & filter logic #15768

miamihotline · 2021-10-21T11:26:17Z

Implemented sorting functionality to Example Selector widget.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

`ValidatesRunner` compliance status (on master branch)

Lang	ULR	Twister2
Go	---	---
Java
Python	---	---
XLang		---

Examples testing status on various runners

Lang	ULR	Dataflow	Flink	Samza	Spark	Twister2
Go	---	---	---	---	---	---	---
Java	---		---	---	---	---	---
Python	---	---	---	---	---	---	---
XLang	---	---	---	---	---	---	---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go	Java	Python

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---			---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

…egion

…logic

# Conflicts: # playground/frontend/lib/pages/playground/components/playground_page_providers.dart # playground/frontend/lib/pages/playground/states/playground_state.dart # playground/frontend/pubspec.lock # playground/frontend/pubspec.yaml

…(added const keyword)

miamihotline · 2021-10-21T11:26:58Z

R: @damondouglas

cc: @pabloem

# Conflicts: # playground/frontend/test/modules/editor/repository/code_repository/code_repository_test.mocks.dart

# Conflicts: # playground/frontend/lib/constants/sizes.dart # playground/frontend/lib/pages/playground/playground_page.dart

# Conflicts: # playground/frontend/lib/constants/sizes.dart # playground/frontend/lib/modules/examples/components/example_list/example_list.dart # playground/frontend/lib/modules/examples/components/filter/category_bubble.dart # playground/frontend/lib/modules/examples/components/filter/type_filter.dart # playground/frontend/lib/modules/examples/components/search_field/search_field.dart # playground/frontend/lib/modules/examples/example_selector.dart # playground/frontend/lib/modules/examples/models/category_model.dart # playground/frontend/lib/modules/examples/models/example_model.dart # playground/frontend/lib/modules/examples/repositories/example_repository.dart # playground/frontend/lib/modules/sdk/components/sdk_selector.dart # playground/frontend/lib/pages/playground/playground_page.dart # playground/frontend/lib/pages/playground/states/examples_state.dart

…tions (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks

… applications (#83)" (#88) This reverts commit b73f5f7.

damondouglas

Hello @miamihotline, after deleting any existing playground/frontend/build directory and running ./gradlew playgroundPrecommit, I receive the following output:

> Task :playground:frontend:pubGet
Running "flutter pub get" in frontend...                         2,512ms

> Task :playground:frontend:analyze
Analyzing ....

   info - lib/pages/playground/playground_page.dart:32:8 - Duplicate import. Try removing all but one import of the library. - duplicate_import
   info - lib/pages/playground/playground_page.dart:33:8 - Duplicate import. Try removing all but one import of the library. - duplicate_import
   info - lib/pages/playground/playground_page.dart:34:8 - Duplicate import. Try removing all but one import of the library. - duplicate_import
   info - lib/pages/playground/playground_page.dart:35:8 - Duplicate import. Try removing all but one import of the library. - duplicate_import
   info - lib/pages/playground/playground_page.dart:36:8 - Duplicate import. Try removing all but one import of the library. - duplicate_import
   info - lib/pages/playground/playground_page.dart:37:8 - Duplicate import. Try removing all but one import of the library. - duplicate_import
   info - lib/pages/playground/playground_page.dart:38:8 - Duplicate import. Try removing all but one import of the library. - duplicate_import

7 issues found.

> Task :playground:frontend:test
00:24 +2: /usr/local/google/home/damondouglas/projects/beam/playground/frontend/test/pages/playground/states/example_selector_state_test.dart: ExampleSelector state sortCategories should:- update categories and notify all listeners,but should NOT:- wait for full name of example,- be sensitive for register,- affect Example state categories
══╡ EXCEPTION CAUGHT BY FOUNDATION LIBRARY ╞════════════════════════════════════════════════════════
The following TestFailure object was thrown while dispatching notifications for
ExampleSelectorState:
  Expected: [Instance of 'CategoryModel']
  Actual: [Instance of 'CategoryModel']
   Which: at location [0] is <Instance of 'CategoryModel'> instead of <Instance of 'CategoryModel'>

When the exception was thrown, this was the stack:
#0      fail (package:test_api/src/expect/expect.dart:137:31)
#1      _expect (package:test_api/src/expect/expect.dart:132:3)
#2      expect (package:test_api/src/expect/expect.dart:46:3)
#3      expect (package:flutter_test/src/widget_tester.dart:461:3)
#4      main.<anonymous closure>.<anonymous closure> (file:///usr/local/google/home/damondouglas/projects/beam/playground/frontend/test/pages/playground/states/example_selector_state_test.dart:65:7)
#5      ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:308:24)
#6      ExampleSelectorState.setCategories (package:playground/pages/playground/states/example_selector_state.dart:54:5)
#7      ExampleSelectorState.sortCategories (package:playground/pages/playground/states/example_selector_state.dart:64:5)
#8      main.<anonymous closure> (file:///usr/local/google/home/damondouglas/projects/beam/playground/frontend/test/pages/playground/states/example_selector_state_test.dart:68:11)
#9      Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:199:19)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)

The ExampleSelectorState sending notification was:
  Instance of 'ExampleSelectorState'
════════════════════════════════════════════════════════════════════════════════════════════════════

miamihotline · 2021-11-18T16:35:43Z

Hello @miamihotline, after deleting any existing playground/frontend/build directory and running ./gradlew playgroundPrecommit, I receive the following output:

Hello, @damondouglas , thank you for reviewing, I fixed analyze issues 5 mins ago

damondouglas

Thank you, @miamihotline, I see the following output. I ran flutter test in the playground/frontend directory. I'm wondering if
the code for expect(state.categories, sortedCategories); should be changed?

00:04 +2: beam/playground/frontend/test/pages/playground/states/example_selector_state_test.dart: ExampleSelector state sortCategories should:- update categories and notify all listeners,but should NOT:- wait for full name of example,- be sensitive for register,- affect Example state categories
══╡ EXCEPTION CAUGHT BY FOUNDATION LIBRARY ╞════════════════════════════════════════════════════════
The following TestFailure object was thrown while dispatching notifications for
ExampleSelectorState:
  Expected: [Instance of 'CategoryModel']
  Actual: [Instance of 'CategoryModel']
   Which: at location [0] is <Instance of 'CategoryModel'> instead of <Instance of 'CategoryModel'>

When the exception was thrown, this was the stack:
#0      fail (package:test_api/src/expect/expect.dart:137:31)
#1      _expect (package:test_api/src/expect/expect.dart:132:3)
#2      expect (package:test_api/src/expect/expect.dart:46:3)
#3      expect (package:flutter_test/src/widget_tester.dart:461:3)
#4      main.<anonymous closure>.<anonymous closure> (beam/playground/frontend/test/pages/playground/states/example_selector_state_test.dart:65:7)
#5      ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:308:24)
#6      ExampleSelectorState.setCategories (package:playground/pages/playground/states/example_selector_state.dart:54:5)
#7      ExampleSelectorState.sortCategories (package:playground/pages/playground/states/example_selector_state.dart:64:5)
#8      main.<anonymous closure> (beam/playground/frontend/test/pages/playground/states/example_selector_state_test.dart:68:11)
#9      Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:199:19)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)

The ExampleSelectorState sending notification was:
  Instance of 'ExampleSelectorState'

miamihotline · 2021-11-18T18:11:21Z

@damondouglas Thank you for pointing that out, fixed this problem

# Conflicts: # playground/frontend/lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart

damondouglas

@pabloem LGTM

miamihotline added 12 commits October 13, 2021 10:06

[BEAM-12967]: Created Examples Component

229b75b

[BEAM-12967]: Wrapped CategoryBubble and ExpansionPanelItem in MouseR…

9d5b229

…egion

[BEAM-13064]: Implemented Search field and Filter by type components …

5a49ae1

…logic

[BEAM-13064]: Fixed names to clarify code, refactored Category model …

5445526

…(added const keyword)

[BEAM-13064]: Increased test coverage of Example Dropdown module

279c4ef

[BEAM-12967] Added generated files

3c577d9

Merge branch 'apache:master' into BEAM-12967

8d04eff

[BEAM-12967]: Added license to generated files

f249c69

Merge remote-tracking branch 'origin/BEAM-12967' into BEAM-13064

573222d

[BEAM-13064]: Fixed sorting functionality, updated tests & mocks

86ccec9

[BEAM-13064]: Refactored code

2960e8e

miamihotline and others added 17 commits October 22, 2021 12:51

Merge remote-tracking branch 'origin/master' into BEAM-12967

36fce7e

# Conflicts: # playground/frontend/test/modules/editor/repository/code_repository/code_repository_test.mocks.dart

[BEAM-12967]: Deleted duplicate files

2c0d3fb

Merge remote-tracking branch 'origin/BEAM-12967' into BEAM-13064

b6cbf17

Merge remote-tracking branch 'origin/master' into BEAM-12967

bb7880f

# Conflicts: # playground/frontend/lib/constants/sizes.dart # playground/frontend/lib/pages/playground/playground_page.dart

Merge remote-tracking branch 'origin/BEAM-12967' into BEAM-13064

44e5964

[BEAM-13064] Fixes after merge

7888359

Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground…

d449275

… applications (#83)" (#88) This reverts commit b73f5f7.

Merge branch 'apache:master' into master

69d0191

Merge branch 'apache:master' into master

1bf7f6f

Merge branch 'apache:master' into master

72bad55

Merge branch 'apache:master' into master

1d6783e

Merge branch 'apache:master' into master

3a81f54

Merge branch 'apache:master' into master

d9cce13

Merge remote-tracking branch 'origin/master' into BEAM-13064

124b58b

[BEAM-13064] Fixed analyze issues

4e8ec3f

damondouglas requested changes Nov 18, 2021

View reviewed changes

[BEAM-13064] Fixed example selector state test

d445d02

daria.malkova and others added 2 commits November 19, 2021 11:19

Merge branch 'apache:master' into master

c24b695

Merge remote-tracking branch 'origin/master' into BEAM-13064

13552bc

# Conflicts: # playground/frontend/lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart

damondouglas approved these changes Nov 19, 2021

View reviewed changes

pabloem merged commit b6bc642 into apache:master Nov 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BEAM-13064] [Playground] Implement search & filter logic #15768

[BEAM-13064] [Playground] Implement search & filter logic #15768

Uh oh!

miamihotline commented Oct 21, 2021 •

edited

Loading

Uh oh!

miamihotline commented Oct 21, 2021

Uh oh!

damondouglas left a comment

Uh oh!

miamihotline commented Nov 18, 2021 •

edited

Loading

Uh oh!

damondouglas left a comment

Uh oh!

miamihotline commented Nov 18, 2021

Uh oh!

damondouglas left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[BEAM-13064] [Playground] Implement search & filter logic #15768

[BEAM-13064] [Playground] Implement search & filter logic #15768

Uh oh!

Conversation

miamihotline commented Oct 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implemented sorting functionality to Example Selector widget.

ValidatesRunner compliance status (on master branch)

Examples testing status on various runners

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Pre-Commit Tests Status (on master branch)

GitHub Actions Tests Status (on master branch)

Uh oh!

miamihotline commented Oct 21, 2021

Uh oh!

damondouglas left a comment

Choose a reason for hiding this comment

Uh oh!

miamihotline commented Nov 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

damondouglas left a comment

Choose a reason for hiding this comment

Uh oh!

miamihotline commented Nov 18, 2021

Uh oh!

damondouglas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

miamihotline commented Oct 21, 2021 •

edited

Loading

`ValidatesRunner` compliance status (on master branch)

miamihotline commented Nov 18, 2021 •

edited

Loading