[BEAM-13210] [Playground]: support streaming output on the frontend #15956
Conversation
|
cc: @pabloem |
|
|
||
| const String kApiClientURL = 'https://datatokenization.uc.r.appspot.com'; | ||
| const String kApiClientURL = | ||
| 'https://backend-dot-datatokenization.uc.r.appspot.com'; |
There was a problem hiding this comment.
May we consider not hardcoding the URL in the codebase? Apologies that I missed it in an earlier review. One possible way to solve it is using a config.json file like this and this. The friction, however, is that it requires creating and maintaining this file. Perhaps we can add a gradle task that creates this config, acquiring the endpoint URL from a gradle.properties file in playground/frontend/gradle.properties.
There was a problem hiding this comment.
@damondouglas, thank you for the suggestion. I pushed a task to generate config.g.dart file, could you please check it?
I chose to generate a dart config file, because it's easier to use in code.
…tions (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks
# Conflicts: # playground/frontend/build.gradle
There was a problem hiding this comment.
Hello @ElessarST First I deleted any existing beam/frontend/build directory and ran ./gradlew playgroundPrecommit and received an error. Then I ran :playground:frontend:pubGet again and it worked. We should probably update our gradle task to delete any existing build directory in the frontend. I'm going to continue to review this PR.
There was a problem hiding this comment.
@ElessarST great work.
@pabloem LGTM
I created https://issues.apache.org/jira/browse/BEAM-13285 as a followup ticket.
5 participants
Please add a meaningful description for your change here
I added support streaming output and handling new execution statuses on the frontend.
Now execution status provides an output that is showing at the UI before finishing execution.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.