[BEAM-13101] [Playground] load examples using the api #16002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # playground/frontend/lib/pages/playground/components/playground_page_providers.dart # playground/frontend/lib/pages/playground/states/playground_state.dart # playground/frontend/pubspec.lock # playground/frontend/pubspec.yaml
…(added const keyword)
# Conflicts: # playground/frontend/test/modules/editor/repository/code_repository/code_repository_test.mocks.dart
# Conflicts: # playground/frontend/lib/constants/sizes.dart # playground/frontend/lib/pages/playground/playground_page.dart
# Conflicts: # playground/frontend/lib/pages/playground/playground_page.dart
…n to use precompiled Outputs
# Conflicts: # playground/api/v1/api.proto # playground/backend/internal/api/v1/api.pb.go # playground/backend/internal/api/v1/api_grpc.pb.go # playground/frontend/lib/api/v1/api.pb.dart # playground/frontend/lib/api/v1/api.pbenum.dart # playground/frontend/lib/api/v1/api.pbgrpc.dart # playground/frontend/lib/api/v1/api.pbjson.dart # playground/frontend/lib/constants/assets.dart # playground/frontend/lib/constants/sizes.dart # playground/frontend/lib/modules/actions/components/new_example_action.dart # playground/frontend/lib/modules/editor/components/editor_textarea.dart # playground/frontend/lib/modules/examples/components/example_list/category_expansion_panel.dart # playground/frontend/lib/modules/examples/components/example_list/example_list.dart # playground/frontend/lib/modules/examples/components/example_list/expansion_panel_item.dart # playground/frontend/lib/modules/examples/components/filter/category_bubble.dart # playground/frontend/lib/modules/examples/components/filter/type_filter.dart # playground/frontend/lib/modules/examples/components/search_field/search_field.dart # playground/frontend/lib/modules/examples/example_selector.dart # playground/frontend/lib/modules/examples/models/category_model.dart # playground/frontend/lib/modules/examples/models/example_model.dart # playground/frontend/lib/modules/examples/repositories/example_repository.dart # playground/frontend/lib/modules/output/components/output_area.dart # playground/frontend/lib/modules/sdk/components/sdk_selector.dart # playground/frontend/lib/pages/playground/components/editor_textarea_wrapper.dart # playground/frontend/lib/pages/playground/components/playground_page_footer.dart # playground/frontend/lib/pages/playground/components/playground_page_providers.dart # playground/frontend/lib/pages/playground/playground_page.dart # playground/frontend/lib/pages/playground/states/examples_state.dart # playground/frontend/lib/pages/playground/states/playground_state.dart # playground/frontend/test/pages/playground/states/mocks/example_mock.dart # playground/frontend/test/pages/playground/states/playground_state_test.dart
…tions (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks
Contributor
Author
|
cc: @pabloem |
Contributor
There was a problem hiding this comment.
@ElessarST did ./gradlew playgroundPrecommit give you the same error output as I saw?
Task :playground:frontend:analyze
Analyzing ....
error - test/pages/playground/states/example_selector_state_test.dart:28:8 - Target of URI doesn't exist: 'example_selector_state_test.mocks.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - test/pages/playground/states/example_selector_state_test.dart:32:30 - The function 'MockExampleClient' isn't defined. Try importing the library that defines 'MockExampleClient', correcting the name to the name of an existing function, or defining a function named 'MockExampleClient'. - undefined_function
Contributor
Author
@damondouglas sorry, one file was not pushed |
damondouglas
requested changes
Nov 18, 2021
Contributor
There was a problem hiding this comment.
Hello @ElessarST thank you for all this work. When I run buf lint in the beam/playground directory, I receive the following output. Did we want to follow its recommendation?
api/v1/api.proto:49:3:Enum value name "EXAMPLE" should be prefixed with "PRECOMPILED_OBJECT_TYPE_".
api/v1/api.proto:49:3:Enum zero value name "EXAMPLE" should be suffixed with "_UNSPECIFIED".
api/v1/api.proto:50:3:Enum value name "KATA" should be prefixed with "PRECOMPILED_OBJECT_TYPE_".
api/v1/api.proto:51:3:Enum value name "UNIT_TEST" should be prefixed with "PRECOMPILED_OBJECT_TYPE_".
api/v1/api.proto:164:3:".api.v1.GetRunOutputResponse" is used as the request or response type for multiple RPCs.
api/v1/api.proto:179:3:".api.v1.GetPrecompiledObjectRequest" is used as the request or response type for multiple RPCs.
api/v1/api.proto:179:32:RPC request type "GetPrecompiledObjectRequest" should be named "GetPrecompiledObjectCodeRequest" or "PlaygroundServiceGetPrecompiledObjectCodeRequest".
api/v1/api.proto:182:3:".api.v1.GetPrecompiledObjectRequest" is used as the request or response type for multiple RPCs.
api/v1/api.proto:182:3:".api.v1.GetRunOutputResponse" is used as the request or response type for multiple RPCs.
api/v1/api.proto:182:34:RPC request type "GetPrecompiledObjectRequest" should be named "GetPrecompiledObjectOutputRequest" or "PlaygroundServiceGetPrecompiledObjectOutputRequest".
api/v1/api.proto:182:72:RPC response type "GetRunOutputResponse" should be named "GetPrecompiledObjectOutputResponse" or "PlaygroundServiceGetPrecompiledObjectOutputResponse".
Contributor
|
Hello @damondouglas, thank you for the suggestion, I fixed this issue, please review this PR again |
# Conflicts: # playground/frontend/lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart
# Conflicts: # playground/frontend/lib/modules/examples/components/search_field/search_field.dart # playground/frontend/lib/modules/examples/example_selector.dart # playground/frontend/lib/modules/examples/models/category_model.dart # playground/frontend/lib/modules/examples/repositories/example_repository.dart # playground/frontend/lib/modules/examples/repositories/models/get_list_of_examples_request.dart # playground/frontend/lib/pages/playground/playground_page.dart # playground/frontend/lib/pages/playground/states/example_selector_state.dart # playground/frontend/lib/pages/playground/states/examples_state.dart # playground/frontend/test/pages/playground/states/example_selector_state_test.dart # playground/frontend/test/pages/playground/states/mocks/categories_mock.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update examples to work with the API instead of using mocks
https://issues.apache.org/jira/browse/BEAM-13101
Depends on the implementation #15957
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.