-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-13307][Playground] Support Python SDK #16050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-13307][Playground] Support Python SDK #16050
Conversation
…tions (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks
…BEAM-13258-playground-python-sdk # Conflicts: # playground/backend/internal/fs_tool/lc_constructor.go # playground/backend/internal/setup_tools/run_builder/run_builder_setuper.go
Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>
Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>
# Conflicts: # playground/backend/internal/code_processing/code_processing.go # playground/backend/internal/fs_tool/lc_constructor.go # playground/backend/internal/setup_tools/run_builder/run_builder_setuper.go
Codecov Report
@@ Coverage Diff @@
## master #16050 +/- ##
==========================================
+ Coverage 74.58% 83.61% +9.03%
==========================================
Files 640 445 -195
Lines 80861 61404 -19457
==========================================
- Hits 60310 51345 -8965
+ Misses 19582 10059 -9523
+ Partials 969 0 -969 Continue to review full report at Codecov.
|
# Conflicts: # playground/backend/internal/code_processing/code_processing.go
7e8985d to
f44869a
Compare
Fix tests; Update processing of the compile step for python sdk;
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "compile_cmd": "", | |||
| "run_cmd": "python3", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah this is interesting - now that I think about this, we should mention in the README that to update runtime environments, we need to change these config files (we cna leave it for later)
|
|
||
| # Prepare Application | ||
| COPY src /go/src/playground/backend | ||
| #COPY playground /go/src/playground/playground |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line?
| include(":playground:backend") | ||
| include(":playground:frontend") | ||
| include(":playground:backend:containers:java") | ||
| include(":playground:backend:containers:python") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the golang container? is it in review?
| tags containerImageTags() | ||
| buildArgs(['BASE_IMAGE': project.rootProject.hasProperty(["base-image"]) ? | ||
| project.rootProject["base-image"] : | ||
| "apache/beam_python3.7_sdk" ]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also document the places where the Beam container version is chosen in the README (also for later)
|
I've merged, but let's remember to address some of the comments : ) |
[BEAM-13307][Playground] Support Python SDK on backend + Dockerfile
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.