Skip to content

Conversation

@daria-malkova
Copy link
Contributor

[BEAM-13307][Playground] Support Python SDK on backend + Dockerfile


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

snkalinin and others added 21 commits November 16, 2021 14:59
…tions (#83)

* Update workflows for playground

* Attempt to fix tests

* Remove continue on error to catch errors

* Fix linter problem for backend dockerfile

* Update folder to run backend go linter

* Moved flutter test to execution via gradle tasks
…BEAM-13258-playground-python-sdk

# Conflicts:
#	playground/backend/internal/fs_tool/lc_constructor.go
#	playground/backend/internal/setup_tools/run_builder/run_builder_setuper.go
Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>
Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>
# Conflicts:
#	playground/backend/internal/code_processing/code_processing.go
#	playground/backend/internal/fs_tool/lc_constructor.go
#	playground/backend/internal/setup_tools/run_builder/run_builder_setuper.go
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #16050 (42a47e9) into master (13fde03) will increase coverage by 9.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16050      +/-   ##
==========================================
+ Coverage   74.58%   83.61%   +9.03%     
==========================================
  Files         640      445     -195     
  Lines       80861    61404   -19457     
==========================================
- Hits        60310    51345    -8965     
+ Misses      19582    10059    -9523     
+ Partials      969        0     -969     
Impacted Files Coverage Δ
...hon/apache_beam/runners/worker/bundle_processor.py 93.39% <0.00%> (-0.25%) ⬇️
sdks/python/apache_beam/runners/common.py 89.98% <0.00%> (-0.15%) ⬇️
sdks/go/pkg/beam/testing/passert/sum.go
...s/go/pkg/beam/core/runtime/graphx/schema/schema.go
sdks/go/pkg/beam/core/runtime/exec/window.go
sdks/go/pkg/beam/core/graph/bind.go
sdks/go/pkg/beam/core/runtime/exec/data.go
sdks/go/pkg/beam/core/runtime/init.go
sdks/go/pkg/beam/core/runtime/graphx/xlang.go
sdks/go/pkg/beam/core/typex/fulltype.go
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13fde03...42a47e9. Read the comment docs.

@daria-malkova daria-malkova force-pushed the BEAM-13307-playground-python-sdk branch from 7e8985d to f44869a Compare November 24, 2021 09:25
daria-malkova and others added 2 commits November 24, 2021 12:39
Fix tests;
Update processing of the compile step for python sdk;
@@ -0,0 +1,6 @@
{
"compile_cmd": "",
"run_cmd": "python3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah this is interesting - now that I think about this, we should mention in the README that to update runtime environments, we need to change these config files (we cna leave it for later)


# Prepare Application
COPY src /go/src/playground/backend
#COPY playground /go/src/playground/playground
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line?

include(":playground:backend")
include(":playground:frontend")
include(":playground:backend:containers:java")
include(":playground:backend:containers:python")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the golang container? is it in review?

tags containerImageTags()
buildArgs(['BASE_IMAGE': project.rootProject.hasProperty(["base-image"]) ?
project.rootProject["base-image"] :
"apache/beam_python3.7_sdk" ])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also document the places where the Beam container version is chosen in the README (also for later)

@pabloem pabloem merged commit d39cb0a into apache:master Nov 29, 2021
@pabloem
Copy link
Member

pabloem commented Nov 29, 2021

I've merged, but let's remember to address some of the comments : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants