[BEAM-13211][Playground] Add function to find all tagged files #16072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks
implemented method to find all tagged files; added categories.yaml file; added requirements.txt file;
AydarZaynutdinov
force-pushed
the
BEAM-13135-script-to-find-tagged-files
branch
from
f0252fb to
005775b
Compare
Contributor
Author
|
R: @pabloem |
pabloem
reviewed
Nov 29, 2021
Member
pabloem
left a comment
pabloem
left a comment
There was a problem hiding this comment.
This looks good to me. Just added a couple comments.
playground/categories.yaml
Outdated
|
|
||
| categories: | ||
| - Side Input | ||
| - Side Output |
Member
There was a problem hiding this comment.
Suggested change
| - Side Output | |
| - Multiple Outputs |
playground/categories.yaml
Outdated
| - Side Output | ||
| - Testing | ||
| - Schemas | ||
| - Transform |
Member
There was a problem hiding this comment.
maybe add
- Batch
- Streaming
- Combiners
- Dataframes
- Joins
What do you mean by 'transform' here? Maybe we can rneame it to be more clear?
Contributor
Author
There was a problem hiding this comment.
I added all categories which you suggested instead of Transform.
| pass | ||
| has_error = False | ||
| examples = [] | ||
| for root, _, files in os.walk(work_dir): |
Member
There was a problem hiding this comment.
have you ran this? do you know how long it takes to run? just curious
Contributor
Author
There was a problem hiding this comment.
Yes. I have run a little test to check how long this method works. Now it takes about 16 seconds.
AydarZaynutdinov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BEAM-13211]
added function to find all tagged files;
added
categories.yamlfile;added
requirements.txtfile;Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.