[BEAM-13322][Playground] Support Java Unit-tests #16125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
LGTM |
daria-malkova
force-pushed
the
BEAM-13322-support-java-unit-tests
branch
from
72d39fe to
47e1b41
Compare
Contributor
Author
|
R: @pabloem |
ilya-kozyrev
suggested changes
Dec 6, 2021
Contributor
There was a problem hiding this comment.
Seems like we have an error here
code_processing_test.go:628:30: cannot use tt.args.valResult (variable of type *map[string]bool) as map[string]bool value in argument to getRunOrTestCmd (compile)
Contributor
Author
There was a problem hiding this comment.
Everything is fine, can't see the problem
pabloem
reviewed
Dec 6, 2021
Member
pabloem
left a comment
pabloem
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding this feature. Can you address the part with the test case?
Member
There was a problem hiding this comment.
should we add a @Test method here? instead of a normal main method?
Member
|
we need a rebase anyway, so maybe add the |
daria-malkova
force-pushed
the
BEAM-13322-support-java-unit-tests
branch
from
0528676 to
a42c290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BEAM-13322] Support Java Unit-tests
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.