[BEAM-13343][Playground] Support go unit tests #16138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
daria-malkova
force-pushed
the
BEAM-13343-support-go-unit-tests
branch
from
3836593 to
43d0a24
Compare
KhaninArtur
approved these changes
Dec 6, 2021
Contributor
KhaninArtur
left a comment
KhaninArtur
left a comment
There was a problem hiding this comment.
LGTM
Just be sure that this one goes after (and says that it depends on) Java unit tests in the tasks list of PRs to review
daria-malkova
force-pushed
the
BEAM-13343-support-go-unit-tests
branch
2 times, most recently
from
a02a295 to
e72f3a7
Compare
daria-malkova
force-pushed
the
BEAM-13343-support-go-unit-tests
branch
from
e72f3a7 to
61fb10d
Compare
AydarZaynutdinov
suggested changes
Dec 8, 2021
Comment on lines
134
to
145
Contributor
There was a problem hiding this comment.
Could we combine this one?
daria-malkova
force-pushed
the
BEAM-13343-support-go-unit-tests
branch
from
6a5a2d6 to
6c87b92
Compare
added 2 commits
December 8, 2021 15:51
# Conflicts: # playground/backend/internal/code_processing/code_processing.go # playground/backend/internal/setup_tools/builder/setup_builder.go # playground/backend/internal/setup_tools/builder/setup_builder_test.go
daria-malkova
force-pushed
the
BEAM-13343-support-go-unit-tests
branch
from
12dac8b to
d1b5af7
Compare
Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>
AydarZaynutdinov
suggested changes
Dec 9, 2021
| ENTRYPOINT ["/opt/playground/backend/server_go_backend"] | ||
|
|
||
|
|
||
| ENTRYPOINT ["/opt/playground/backend/server_go_backend"] |
Contributor
There was a problem hiding this comment.
add an empty string.
Comment on lines
+91
to
+96
| // Check if unit test | ||
| isUnitTest := false | ||
| valResult, ok := validationResults.Load(validators.UnitTestValidatorName) | ||
| if ok && valResult.(bool) { | ||
| isUnitTest = true | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe wrap it like a separate method?
| const ( | ||
| nameBinGo = "go" | ||
| fmtArgs = "fmt" | ||
| goName = "go" |
Contributor
There was a problem hiding this comment.
maybe goFileExtension instead of goName?
pabloem
reviewed
Dec 10, 2021
| } | ||
| // Check if unit test | ||
| isUnitTest := false | ||
| valResult, ok := validationResults.Load(validators.UnitTestValidatorName) |
Member
There was a problem hiding this comment.
Suggested change
| valResult, ok := validationResults.Load(validators.UnitTestValidatorName) | |
| validateIsUnitTest, ok := validationResults.Load(validators.UnitTestValidatorName) |
| "testing" | ||
| ) | ||
|
|
||
| func TestMain(m *testing.M) { |
Member
There was a problem hiding this comment.
Can you add documentation to this file to explain that it defines some common methods for validators? (I was confused looking for a test within it, but there aren't any tests in it, right?)
Contributor
Author
There was a problem hiding this comment.
Thanks, Pablo, I've added this to PR #16206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BEAM-13343] Add cmd for running go unit tests
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.