-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-13344][Playground] support python unit tests #16179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pabloem
merged 19 commits into
apache:master
from
akvelon:BEAM-13344-support-python-unit-tests
Dec 13, 2021
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9d96a2e
Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground…
ilya-kozyrev 9cc287e
Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground…
ilya-kozyrev 61fb10d
Add go unit tests support
333e544
Add go unit tests support
53c2dc4
Merge conflicts
b4bfccf
support Python unit tests
7f510da
Merge branch 'BEAM-13343-support-go-unit-tests' into BEAM-13344-suppo…
03462ef
bugfix
6c87b92
Add go unit tests support
a8ca785
Merge branch 'master' into BEAM-13343-support-go-unit-tests
d1b5af7
unit tests fixes
531e92f
Merge branch 'BEAM-13343-support-go-unit-tests' into BEAM-13344-suppo…
60f91d6
Merge branch 'master' into BEAM-13343-support-go-unit-tests
82b8c0c
Update playground/backend/internal/executors/executor_test.go
29aad39
Merge branch 'BEAM-13343-support-go-unit-tests' into BEAM-13344-suppo…
c5c6b56
code processing small refactoring
6ca5b2e
Add processing of an error
d8df924
Merge branch 'master' into BEAM-13344-support-python-unit-tests
ccc99fd
Merge branch 'master' into BEAM-13344-support-python-unit-tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| { | ||
| "compile_cmd": "", | ||
| "run_cmd": "python3", | ||
| "test_cmd": "pytest", | ||
| "compile_args": [], | ||
| "run_args": [] | ||
| "run_args": [], | ||
| "test_args": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another option is
(unittest.TestCase).. though I recognize this is hard.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we file a bug to make sure that this works fine? users may accidentaly import unittest without adding an actual test? (maybe?) - perhaps the frontend should show the user that
import unittestwill make the playground run unit tests.