Skip to content

[BEAM-13558] [Playground] Hide the Graph tab and SCIO from SDK options #16369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloem merged 4 commits into from
Jan 21, 2022
Merged

[BEAM-13558] [Playground] Hide the Graph tab and SCIO from SDK options #16369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5b431e
[BEAM-13558] Hid the Graph tab from output area & SCIO from SDK options
miamihotline Dec 27, 2021
ef4660e
[BEAM-13515] Added clarifying comments
miamihotline Dec 28, 2021
a5b3700
Merge remote-tracking branch 'origin/master' into BEAM-13558
miamihotline Jan 10, 2022
7136a9b
Merge remote-tracking branch 'origin/master' into BEAM-13558
miamihotline Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playground/frontend/lib/modules/output/components/output.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class _OutputState extends State<Output> with SingleTickerProviderStateMixin {

@override
void initState() {
tabController = TabController(vsync: this, length: 3);
tabController = TabController(vsync: this, length: 2);
Copy link
Contributor

@damondouglas damondouglas Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miamihotline This comment is not a blocker for this PR but in the future I propose instead of hardcoding the number of tabs in the TabController, having a final variable that is an array of OutputTab widgets and using this variable to assign its length to the TabController length property and assigning this array to the tabs property of the TabBar widget. This way one could add or remove widgets in the TabBar tabs property and never have to remember to also change this number.

tabController.addListener(onTabChange);
super.initState();
}
Expand Down
4 changes: 2 additions & 2 deletions playground/frontend/lib/modules/output/components/output_area.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
*/

import 'package:flutter/material.dart';
import 'package:flutter_gen/gen_l10n/app_localizations.dart';
import 'package:playground/modules/output/components/output_result.dart';
import 'package:playground/pages/playground/states/playground_state.dart';
import 'package:provider/provider.dart';
Expand Down Expand Up @@ -45,7 +44,8 @@ class OutputArea extends StatelessWidget {
text: state.result?.log ?? '',
isSelected: tabController.index == 1,
),
Center(child: Text(AppLocalizations.of(context)!.graph)),
// Not supported yet
// Center(child: Text(AppLocalizations.of(context)!.graph)),
],
);
},
Expand Down
11 changes: 6 additions & 5 deletions playground/frontend/lib/modules/output/components/output_header/output_tabs.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,12 @@ class OutputTabs extends StatelessWidget {
isSelected: tabController.index == 1,
value: state.result?.log ?? '',
),
OutputTab(
name: appLocale.graph,
isSelected: tabController.index == 2,
value: '',
),
// Not supported yet
// OutputTab(
// name: appLocale.graph,
// isSelected: tabController.index == 2,
// value: '',
// ),
],
),
);
Expand Down
7 changes: 5 additions & 2 deletions playground/frontend/lib/modules/sdk/components/sdk_selector.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ typedef SetExample = void Function(ExampleModel example);
const kEmptyExampleName = 'Catalog';

const double kWidth = 150;
const double kHeight = 172;
const double kHeight = 137;

class SDKSelector extends StatelessWidget {
final SDK sdk;
Expand All @@ -58,7 +58,10 @@ class SDKSelector extends StatelessWidget {
createDropdown: (close) => Column(
children: [
const SizedBox(height: kMdSpacing),
...SDK.values.map((SDK value) {
// SCIO is not supported yet
...SDK.values
.where((element) => element != SDK.scio)
.map((SDK value) {
return SizedBox(
width: double.infinity,
child: Consumer<ExampleState>(
Expand Down