Skip to content

[BEAM-13626] Remap expanded outputs after merging expanded components into the existing pipeline. #16471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostluck merged 1 commit into from
Jan 10, 2022
Merged

[BEAM-13626] Remap expanded outputs after merging expanded components into the existing pipeline. #16471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sdks/go/pkg/beam/core/runtime/graphx/translate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,12 @@ func Marshal(edges []*graph.MultiEdge, opt *Options) (*pipepb.Pipeline, error) {

// If there are external transforms that need expanding, do it now.
if m.needsExpansion {
// Remap outputs of expanded external transforms to be the inputs for all downstream consumers
purgeOutputInput(edges, p)
// Merge the expanded components into the existing pipeline
mergeExpandedWithPipeline(edges, p)

// Remap outputs of expanded external transforms to be the inputs for all downstream consumers
// Must happen after merging, so that the inputs in the expanded transforms are also updated.
purgeOutputInput(edges, p)
}

return p, nil
Expand Down