Skip to content

[BEAM-13486] [Playground] For unit tests (java) if one of tests fails the output goes to stdOutput #16485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloem merged 5 commits into from
Jan 13, 2022
Merged

[BEAM-13486] [Playground] For unit tests (java) if one of tests fails the output goes to stdOutput #16485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49845a5
[BEAM-13486] Added errorOutput to output tab
miamihotline Jan 10, 2022
b07c541
Merge remote-tracking branch 'origin/master' into BEAM-13486
miamihotline Jan 10, 2022
aaa468d
[BEAM-13486] Fixed tests for code repository
miamihotline Jan 11, 2022
4f17785
Merge remote-tracking branch 'origin/master' into BEAM-13486
miamihotline Jan 11, 2022
205589f
[BEAM-13486] Fixed runOutputError printing
miamihotline Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions playground/frontend/lib/modules/editor/repository/code_repository/code_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,9 @@ class CodeRepository {
log: prevLog,
);
case RunCodeStatus.executing:
case RunCodeStatus.finished:
final responses = await Future.wait([
_client.getRunOutput(pipelineUuid, request),
_client.getLogOutput(pipelineUuid, request)
_client.getLogOutput(pipelineUuid, request),
]);
final output = responses[0];
final log = responses[1];
Expand All @@ -147,6 +146,20 @@ class CodeRepository {
output: prevOutput + output.output,
log: prevLog + log.output,
);
case RunCodeStatus.finished:
final responses = await Future.wait([
_client.getRunOutput(pipelineUuid, request),
_client.getLogOutput(pipelineUuid, request),
_client.getRunErrorOutput(pipelineUuid, request)
]);
final output = responses[0];
final log = responses[1];
final error = responses[2];
return RunCodeResult(
status: status,
output: prevOutput + output.output + error.output,
log: prevLog + log.output,
);
default:
return RunCodeResult(status: status);
}
Expand Down
7 changes: 5 additions & 2 deletions playground/frontend/test/modules/editor/repository/code_repository/code_repository_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ void main() {
when(client.getCompileOutput(kPipelineUuid, kRequestMock)).thenAnswer(
(_) async => kCompileOutputResponse,
);
when(client.getRunErrorOutput(kPipelineUuid, kRequestMock)).thenAnswer(
(_) async => kRunErrorOutputResponse,
);
when(client.getLogOutput(kPipelineUuid, kRequestMock)).thenAnswer(
(_) async => kLogOutputResponse,
);
Expand All @@ -91,7 +94,7 @@ void main() {
),
RunCodeResult(
status: RunCodeStatus.finished,
output: kRunOutput,
output: kRunOutput + kRunErrorOutput,
log: kProcessingStartedText + kLogOutput,
),
]),
Expand Down Expand Up @@ -234,7 +237,7 @@ void main() {
),
RunCodeResult(
status: RunCodeStatus.finished,
output: kRunOutput * 3,
output: kRunOutput * 3 + kRunErrorOutput,
log: kProcessingStartedText + kLogOutput * 3,
),
]),
Expand Down