Skip to content

[BEAM-13015] Provide caching statistics in the status client. #16495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukecwik merged 4 commits into from
Jan 19, 2022
Merged

[BEAM-13015] Provide caching statistics in the status client. #16495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03311b3
[BEAM-13015] Provide caching statistics in the status client.
lukecwik Jan 12, 2022
dd2d0fd
Address PR comments.
lukecwik Jan 14, 2022
91f1aa9
Address PR comments.
lukecwik Jan 18, 2022
6d1b8a5
Address PR comments by weighing the key.
lukecwik Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/util/WeightedValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
*/
package org.apache.beam.sdk.util;

import java.util.Objects;
import javax.annotation.Nullable;
import org.apache.beam.sdk.annotations.Internal;

/**
Expand Down Expand Up @@ -47,4 +49,26 @@ public long getWeight() {
public T getValue() {
return value;
}

@Override
public boolean equals(@Nullable Object o) {
if (this == o) {
return true;
}
if (!(o instanceof WeightedValue)) {
Copy link
Contributor

@scwhittle scwhittle Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check for null?

Copy link
Member Author

@lukecwik lukecwik Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null instanceof X is always false so checking for null is redundant.

return false;
}
WeightedValue<?> that = (WeightedValue<?>) o;
return weight == that.weight && Objects.equals(value, that.value);
}

@Override
public int hashCode() {
return Objects.hash(value, weight);
}

@Override
public String toString() {
return "WeightedValue{value=" + value + ", weight=" + weight + "}";
}
}
3 changes: 3 additions & 0 deletions sdks/java/harness/src/main/java/org/apache/beam/fn/harness/Cache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,7 @@ interface Shrinkable<V> {

/** Removes the mapping for a key from the cache if it is present. */
void remove(K key);

/** Returns a string containing caching statistics. */
String describeStats();
}
Loading