-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Make num-stages counter into an internal counter. #16638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This unbreaks tests that (arguably to brittly) reject extra counters.
|
Run Python PreCommit |
| str(type(self)), | ||
| self.NUM_FUSED_STAGES_COUNTER, | ||
| urn='internal:' + self.NUM_FUSED_STAGES_COUNTER)).update( | ||
| len(stages)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess internal: is a concept already defined somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there's some inconsistencies here with "user" counters requiring a name and namespace and "non-user" counters using the first component of the urn as a namespace and the rest as the name.
|
The failing tests apache_beam.transforms.create_test.CreateTest.test_create_uses_coder_for_pickling look unrelated. Trying again. |
|
Run Python PreCommit |
|
Run Python PreCommit |
|
I tried deflaking the Actions tests but it's unlikely to work since the rate of flakes is so high, there's no way to re-run individual actions, and the flakes can affect 8 different actions... I'm just going to merge this |
|
I suppose the merge ref is likely just created once when the PR is created and not updated. |

This unbreaks tests that (arguably to brittly) reject extra counters.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.