[BEAM-11971] Fix directrunner timer consistency #16650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuvenlax
force-pushed
the
fix_directrunner_looping_timer
branch
3 times, most recently
from
2f4de0b to
a8c89ba
Compare
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Run Java_PVR_Flink_Batch PreCommit |
reuvenlax
changed the title
Contributor
Author
|
R: @rezarokni |
Contributor
Author
|
Run Java PreCommit |
je-ik
reviewed
Feb 1, 2022
Contributor
je-ik
left a comment
je-ik
left a comment
There was a problem hiding this comment.
The only thing I'm not sure how is how setting looping timer in earlierTimers should work. Could we maybe test that explicitly with a unit test?
.../direct-java/src/main/java/org/apache/beam/runners/direct/StatefulParDoEvaluatorFactory.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
The construction of the timerKey seems repeated, could we wrap it in a helper method?
Contributor
Author
There was a problem hiding this comment.
Cleaned up timerKey usage
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
Outdated
Show resolved
Hide resolved
je-ik
reviewed
Feb 2, 2022
Contributor
je-ik
left a comment
je-ik
left a comment
There was a problem hiding this comment.
LGTM.
nit: maybe we could slightly improve the stringKey for better readability.
runners/core-java/src/main/java/org/apache/beam/runners/core/TimerInternals.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Run Java PreCommit |
Member
|
CC: @kileys |
reuvenlax
force-pushed
the
fix_directrunner_looping_timer
branch
from
83d976b to
8ea77f9
Compare
|
@reuvenlax - we rolled this back because several tests were failing #16748 |
Contributor
Author
|
Which tests were failing?
…On Mon, Feb 7, 2022 at 3:04 PM Kyle Weaver ***@***.***> wrote:
@reuvenlax <https://github.com/reuvenlax> - we rolled this back because
several tests were failing #16748
<#16748>
—
Reply to this email directly, view it on GitHub
<#16650 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAYJVPLXNAUMCN4QBXCZULU2BFYNANCNFSM5NCOGP3A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.