-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Sharding vortex #16795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharding vortex #16795
Conversation
|
Run Java PreCommit |
|
R: @reuvenlax |
...google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiLoads.java
Outdated
Show resolved
Hide resolved
36d5ee3 to
64cae5c
Compare
312bbad to
c158a48
Compare
Codecov Report
@@ Coverage Diff @@
## master #16795 +/- ##
==========================================
+ Coverage 73.98% 83.62% +9.64%
==========================================
Files 713 453 -260
Lines 94048 62471 -31577
==========================================
- Hits 69582 52242 -17340
+ Misses 23180 10229 -12951
+ Partials 1286 0 -1286
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I triggered the tests. I am not sure what is the next step after that. @Naireen - it would be good to add a jira in the issue title with some explanation of what you are trying to do. |
|
LGTM, however please attach a JIRA to the title |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
57a136e to
c02ec57
Compare
|
Run Java PreCommit |
|
run java precommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does autosharding default to true or false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Write method sets autosharding as false by default:
Line 1768 in 0fbecde
| .setAutoSharding(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we push this to a helper method to improve readability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored, PTAL.
|
LGTM |
c02ec57 to
3ada51d
Compare
3ada51d to
ec3bcf3
Compare
|
Run Spotless PreCommit |
|
Run Java PreCommit |
Enable autosharding for BQ: #22818
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.