Skip to content

Conversation

@victorplusc
Copy link
Contributor

@victorplusc victorplusc commented Feb 24, 2022

Bug fix: removing the 'No cluster_manager is associated with the provided pipeline!' logger error message when a pipeline is present, but has no cluster manager. The bug in this scenario is that this case can be triggered when the user uses Interactive Beam in a way that automatically cleans up an individual pipeline (e.g. running InteractiveRunner() using a with clause).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@victorplusc
Copy link
Contributor Author

R: @kevingg
R: @rohdesamuel

Copy link
Contributor

@nika-qubit nika-qubit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #16936 (c44b4f9) into master (0e45de7) will increase coverage by 36.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #16936       +/-   ##
===========================================
+ Coverage   46.89%   83.62%   +36.73%     
===========================================
  Files         204      453      +249     
  Lines       20122    62478    +42356     
===========================================
+ Hits         9436    52247    +42811     
- Misses       9686    10231      +545     
+ Partials     1000        0     -1000     
Flag Coverage Δ
python 83.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pache_beam/runners/interactive/interactive_beam.py 81.17% <ø> (ø)
sdks/go/pkg/beam/core/runtime/pipelinex/util.go
sdks/go/pkg/beam/runners/direct/buffer.go
sdks/go/pkg/beam/core/runtime/xlangx/expand.go
sdks/go/pkg/beam/core/graph/coder/map.go
sdks/go/pkg/beam/testing/passert/equals.go
sdks/go/pkg/beam/core/runtime/graphx/user.go
...kg/beam/core/runtime/xlangx/expansionx/download.go
sdks/go/pkg/beam/core/runtime/coderx/string.go
sdks/go/pkg/beam/core/runtime/graphx/cogbk.go
... and 648 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e45de7...c44b4f9. Read the comment docs.

@nika-qubit nika-qubit merged commit cc16171 into apache:master Feb 24, 2022
@victorplusc victorplusc deleted the removing_no_cluster_manager_logger_error branch February 24, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants