Skip to content

Clean up Go formatter suggestions #16973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostluck merged 2 commits into from
Mar 1, 2022
Merged

Clean up Go formatter suggestions #16973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a356cca
Go fmt clean-up
jrmccluskey Feb 28, 2022
52f63b6
Add gen files to formatting change
jrmccluskey Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions sdks/go/pkg/beam/core/runtime/exec/sideinput_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,26 +67,26 @@ func TestNewSideInputAdapter(t *testing.T) {
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
adapter := NewSideInputAdapter(test.sid, test.sideInputID, test.c, nil)
adapterStruct, ok := adapter.(*sideInputAdapter)
if !ok {
t.Errorf("failed to convert interface to sideInputAdapter struct in test %v", test)
}
if got, want := adapterStruct.sid, test.sid; got != want {
t.Errorf("got SID %v, want %v", got, want)
}
if got, want := adapterStruct.sideInputID, test.sideInputID; got != want {
t.Errorf("got sideInputID %v, want %v", got, want)
}
if got, want := adapterStruct.c, test.c; got != want {
t.Errorf("got coder %v, want %v", got, want)
}
if got, want := reflect.TypeOf(adapterStruct.kc), reflect.TypeOf(test.kc); got != want {
t.Errorf("got ElementEncoder type %v, want %v", got, want)
}
if got, want := reflect.TypeOf(adapterStruct.ec), reflect.TypeOf(test.ec); got != want {
t.Errorf("got ElementDecoder type %v, want %v", got, want)
}
adapter := NewSideInputAdapter(test.sid, test.sideInputID, test.c, nil)
adapterStruct, ok := adapter.(*sideInputAdapter)
if !ok {
t.Errorf("failed to convert interface to sideInputAdapter struct in test %v", test)
}
if got, want := adapterStruct.sid, test.sid; got != want {
t.Errorf("got SID %v, want %v", got, want)
}
if got, want := adapterStruct.sideInputID, test.sideInputID; got != want {
t.Errorf("got sideInputID %v, want %v", got, want)
}
if got, want := adapterStruct.c, test.c; got != want {
t.Errorf("got coder %v, want %v", got, want)
}
if got, want := reflect.TypeOf(adapterStruct.kc), reflect.TypeOf(test.kc); got != want {
t.Errorf("got ElementEncoder type %v, want %v", got, want)
}
if got, want := reflect.TypeOf(adapterStruct.ec), reflect.TypeOf(test.ec); got != want {
t.Errorf("got ElementDecoder type %v, want %v", got, want)
}
})
}
}
Expand Down
2 changes: 1 addition & 1 deletion sdks/go/pkg/beam/util/harnessopts/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// Package harnessopts defines user-facing entrypoints into Beam hooks
// Package harnessopts defines user-facing entrypoints into Beam hooks
// affecting the SDK harness. Call these functions at any time before
// submitting your pipeline to a runner, for that pipeline's workers to be affected.
package harnessopts
Expand Down
1 change: 1 addition & 0 deletions sdks/go/pkg/beam/util/syscallx/syscall_default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//go:build !linux
// +build !linux

package syscallx
Expand Down
1 change: 1 addition & 0 deletions sdks/go/pkg/beam/util/syscallx/syscall_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//go:build linux
// +build linux

package syscallx
Expand Down