Skip to content

[BEAM-14012] Add go fmt to Github Actions #16978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostluck merged 2 commits into from
Mar 1, 2022
Merged

[BEAM-14012] Add go fmt to Github Actions #16978

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22c6169
[BEAM-14012] Add go fmt to Github Actions
jrmccluskey Mar 1, 2022
7f4e785
Add fail logic to vet check too
jrmccluskey Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/go_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,7 @@ jobs:
flags: go
files: ./sdks/go/pkg/coverage.txt
name: go-unittests
- name: Run fmt
run: cd sdks/go/pkg/beam && go fmt ./...; git diff-index --quiet HEAD || (echo "Run go fmt before checking in changes" && exit 1)
Copy link
Contributor

@damccorm damccorm Mar 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using cd, you can specify a working-directory (see

beam/.github/workflows/python_tests.yml

Lines 77 to 79 in b07840e

- name: Get build dependencies
working-directory: ./sdks/python
run: pip install pip setuptools --upgrade && pip install -r build-requirements.txt
for an example). Its not a bad idea to update the rest of the file, but I'll leave that to your discretion.

- name: Run vet
run: cd sdks/go/pkg/beam && go vet --copylocks=false --unsafeptr=false ./...
run: cd sdks/go/pkg/beam && go vet --copylocks=false --unsafeptr=false ./... || (echo "Run go vet and fix warnings before checking in changes" && exit 1)