[BEAM-151] Enable integration tests underneath google-cloud-dataflow-java #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…java Added surefire.dependencyToScan and surefire.testPipelineOptions configuration options surefire.dependencyToScan adds an additional dependency used to find tests. This allows for java-sdk-all to be added to all runners for running the @category(RunnableOnService.class) tests. surefire.testPipelineOptions configures the pipeline options used while constructing instances of a TestPipeline. A json list of arguments is expected, for example: [ "--runner=MyRunner", "--myRunnerOption=myRunnerValue" ]
Member
Author
|
R: @davorbonaci Please review and after merge update Jenkins to use: Where -Ddataflow.testPipelineOptions replaces -DdataflowOptions Currently this change will run all the java-sdk-all tests while building that module and then the @category(RunnableOnService.class) tests found in both java-sdk-all and google-cloud-dataflow-java using the Dataflow runner. |
Member
Author
|
Will revisit how this is being done and potentially come up with new proposal. |
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
damccorm
pushed a commit
that referenced
this pull request
Dec 9, 2022
…#23140) * Updated go_tests Workflow (#170) Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> * Added master changes in go_tests to avoid merge conflicts * Re adding the fetch-depth: 2 in checkout step in Go Test workflow * Switching trigger to pull_request (#262) * Switching trigger to pull_request * Removing ref from checkout Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com> Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> Co-authored-by: elink22 <103056145+elink22@users.noreply.github.com>
lostluck
pushed a commit
to lostluck/beam
that referenced
this pull request
Dec 22, 2022
…apache#23140) * Updated go_tests Workflow (apache#170) Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> * Added master changes in go_tests to avoid merge conflicts * Re adding the fetch-depth: 2 in checkout step in Go Test workflow * Switching trigger to pull_request (apache#262) * Switching trigger to pull_request * Removing ref from checkout Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com> Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> Co-authored-by: elink22 <103056145+elink22@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
number, if there is one.
Individual Contributor License Agreement.
Added surefire.dependencyToScan and surefire.testPipelineOptions configuration options
surefire.dependencyToScan adds an additional dependency used to find tests.
This allows for java-sdk-all to be added to all runners for running
the @category(RunnableOnService.class) tests.
surefire.testPipelineOptions configures the pipeline options used while
constructing instances of a TestPipeline. A json list of arguments
is expected, for example:
[ "--runner=MyRunner", "--myRunnerOption=myRunnerValue" ]