Skip to content

Conversation

@dpcollins-google
Copy link
Contributor

This ensures they do not materialize all data at once for large requests


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

This ensures they do not materialize all data at once for large requests
This ensures they do not materialize all data at once for large requests
This ensures they do not materialize all data at once for large requests
This ensures they do not materialize all data at once for large requests
This ensures they do not materialize all data at once for large requests
@dpcollins-google
Copy link
Contributor Author

Run Java PreCommit

Copy link
Contributor

@scwhittle scwhittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though you'll have to find someone else to merge

@scwhittle
Copy link
Contributor

Run Java PreCommit

@TheNeuralBit
Copy link
Member

Is there a jira for this that we can tag?

@dpcollins-google dpcollins-google changed the title Chunk commit requests dynamically [BEAM-14116] Chunk commit requests dynamically Mar 16, 2022
@TheNeuralBit TheNeuralBit merged commit 8ae7628 into apache:master Mar 16, 2022
@lukecwik
Copy link
Member

This change breaks the cloud/dataflow/testing/integration/sdk:streaming_GroupByKeyTest_BasicTests_testLargeKeys1MB_wm_service_local test reliably for Dataflow.

@youngoli Resolution of whether this should be rolled back or forward fixed looks like will impact the 2.38 release.

@youngoli
Copy link
Contributor

I'm open to cherry-picking in a forward fix since this was caught so soon after the cut. I just need an estimate of how long a fix would take to implement (I can wait a bit for this to get triaged so we can get an estimate). If a fix would take more than three days or so then probably better to just roll back.

youngoli added a commit to youngoli/beam that referenced this pull request Mar 31, 2022
youngoli added a commit that referenced this pull request Apr 1, 2022
…lback of #17004: Chunk commit requests dynamically

[rollback][release-2.38.0][BEAM-14116] Rollback of #17004: Chunk commit requests dynamically
emilymye added a commit to emilymye/beam that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants