-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-14116] Chunk commit requests dynamically #17004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This ensures they do not materialize all data at once for large requests
This ensures they do not materialize all data at once for large requests
...orker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
Outdated
Show resolved
Hide resolved
...orker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
Show resolved
Hide resolved
...orker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
Show resolved
Hide resolved
This ensures they do not materialize all data at once for large requests
...orker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
Outdated
Show resolved
Hide resolved
...orker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
Outdated
Show resolved
Hide resolved
This ensures they do not materialize all data at once for large requests
This ensures they do not materialize all data at once for large requests
|
Run Java PreCommit |
scwhittle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though you'll have to find someone else to merge
...orker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
Show resolved
Hide resolved
|
Run Java PreCommit |
|
Is there a jira for this that we can tag? |
|
This change breaks the cloud/dataflow/testing/integration/sdk:streaming_GroupByKeyTest_BasicTests_testLargeKeys1MB_wm_service_local test reliably for Dataflow. @youngoli Resolution of whether this should be rolled back or forward fixed looks like will impact the 2.38 release. |
|
I'm open to cherry-picking in a forward fix since this was caught so soon after the cut. I just need an estimate of how long a fix would take to implement (I can wait a bit for this to get triaged so we can get an estimate). If a fix would take more than three days or so then probably better to just roll back. |
This reverts commit 8ae7628.
…lback of #17004: Chunk commit requests dynamically [rollback][release-2.38.0][BEAM-14116] Rollback of #17004: Chunk commit requests dynamically
This reverts commit 8ae7628.
This ensures they do not materialize all data at once for large requests
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.