[BEAM-14185]: remove the metadata table after the pipeline finishes for Spanner Change Streams Connector #17182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagotnunes
approved these changes
Mar 25, 2022
Contributor
|
retest this please |
hengfengli
changed the title
Modifies integration test to check that metadata table is dropped in the end of the execution of the SpannerIO.readChangeStream connector.
Contributor
|
retest this please |
Contributor
|
Test failures are unrelated (BigQuery test) |
Contributor
|
Run Java PostCommit |
Contributor
|
Run Java PostCommit |
1 similar comment
Member
|
Run Java PostCommit |
Disable flaky tests for SpannerIO.readChangeStream.
Contributor
|
Disabled flaky SpannerIO.readChangeStream tests. Created a ticket to re-enable them (https://issues.apache.org/jira/browse/BEAM-14195) |
Contributor
|
R: @pabloem |
Member
|
LGTM |
youngoli
pushed a commit
to youngoli/beam
that referenced
this pull request
Mar 30, 2022
…a table after the pipeline finishes for Spanner Change Streams Connector [BEAM-14185]: remove the metadata table after the pipeline finishes for Spanner Change Streams Connector
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the metadata table after the pipeline finishes. But note that if the pipeline is cancelled, the metadata table would not be deleted.