Skip to content

JMH benchmarks on reading field values from RowWithGetters. #17203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mosche wants to merge 1 commit into from
Closed

JMH benchmarks on reading field values from RowWithGetters. #17203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,7 +1417,14 @@ class BeamModulePlugin implements Plugin<Project> {
// that ends up on the runtime classpath.
args 'org.apache.beam'
}
args '-i=3'
args '-wi=3'
args '-f=3'
args '-r=20s'
args '-gc=true'

args '-foe=true'
args '-rf=json'
}

// Single shot of JMH benchmarks ensures that they can execute.
Expand Down
20 changes: 16 additions & 4 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,29 +53,41 @@ public class RowWithGetters extends Row {
private final Factory<List<FieldValueGetter>> fieldValueGetterFactory;
private final Object getterTarget;
private final List<FieldValueGetter> getters;
private final boolean useCache;

private final Map<Integer, Collection> cachedCollections = Maps.newHashMap();
private final Map<Integer, Iterable> cachedIterables = Maps.newHashMap();
private final Map<Integer, Map> cachedMaps = Maps.newHashMap();
private Map<Integer, Collection> cachedCollections = null;
private Map<Integer, Iterable> cachedIterables = null;
private Map<Integer, Map> cachedMaps = null;

private void initCache() {
cachedCollections = Maps.newHashMap();
cachedIterables = Maps.newHashMap();
cachedMaps = Maps.newHashMap();
}

RowWithGetters(
Schema schema, Factory<List<FieldValueGetter>> getterFactory, Object getterTarget) {
super(schema);
this.fieldValueGetterFactory = getterFactory;
this.getterTarget = getterTarget;
this.getters = fieldValueGetterFactory.create(getterTarget.getClass(), schema);
this.useCache = schema.getOptions().hasOption("nocache") == false;
}

@Override
@SuppressWarnings({"TypeParameterUnusedInFormals", "unchecked"})
public <T> @Nullable T getValue(int fieldIdx) {
// lazy init cache on first getValue to include initialization costs into benchmark
if (cachedCollections == null) {
initCache();
}
Field field = getSchema().getField(fieldIdx);
FieldType type = field.getType();
Object fieldValue = getters.get(fieldIdx).get(getterTarget);
if (fieldValue == null && !field.getType().getNullable()) {
throw new RuntimeException("Null value set on non-nullable field " + field);
}
return fieldValue != null ? getValue(type, fieldValue, fieldIdx) : null;
return fieldValue != null ? getValue(type, fieldValue, useCache ? fieldIdx : null) : null;
}

private Collection getCollectionValue(FieldType elementType, Object fieldValue) {
Expand Down
Loading