[cherry-pick][release-2.38.0][BEAM-14194]: Disallow autoscaling for SpannerIO.readChangeStream #17218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng for SpannerIO.readChangeStream SpannerIO.readChangeStream does not support autoscaling at the moment. In order to avoid customer confusion, we decided to throw an error if any algorithm is specified other than NONE. (cherry picked from commit a090e90)
Contributor
Author
|
R: @TheNeuralBit @thiagotnunes @pabloem (whoever gets to it first) |
Contributor
|
Run Java PostCommit |
Contributor
|
The only SpannerChangeStreams PostCommit tests failing are the ones being ignored in #17217, because they are flaky. Other failures are unrelated to our Spanner Change Streams. |
TheNeuralBit
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpannerIO.readChangeStream does not support autoscaling at the moment.
In order to avoid customer confusion, we decided to throw an error if
any algorithm is specified other than NONE.
(cherry picked from commit a090e90)
Cherry-pick of PR #17202
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.