Skip to content

Conversation

@kileys
Copy link
Contributor

@kileys kileys commented Apr 2, 2022

This reverts commit c50f562.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the python label Apr 2, 2022
@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #17255 (c2cdd75) into master (0ab181f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #17255   +/-   ##
=======================================
  Coverage   74.16%   74.17%           
=======================================
  Files         675      675           
  Lines       88901    88896    -5     
=======================================
+ Hits        65934    65935    +1     
+ Misses      21832    21826    -6     
  Partials     1135     1135           
Flag Coverage Δ
python 83.68% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/coders/row_coder.py 97.00% <ø> (-0.15%) ⬇️
...ks/python/apache_beam/runners/worker/data_plane.py 87.50% <0.00%> (-1.71%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.64% <0.00%> (+0.12%) ⬆️
...eam/runners/interactive/interactive_environment.py 90.51% <0.00%> (+0.30%) ⬆️
...runners/interactive/display/pcoll_visualization.py 86.36% <0.00%> (+0.50%) ⬆️
...pache_beam/runners/interactive/interactive_beam.py 81.81% <0.00%> (+0.72%) ⬆️
...eam/runners/portability/fn_api_runner/execution.py 93.06% <0.00%> (+0.80%) ⬆️
.../python/apache_beam/transforms/periodicsequence.py 98.36% <0.00%> (+1.63%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab181f...c2cdd75. Read the comment docs.

Copy link
Member

@apilloud apilloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kileys kileys changed the title [TESTING] Revert "[BEAM-14190] Python sends dataflow schema field" [BEAM-14231] Revert "[BEAM-14190] Python sends dataflow schema field" Apr 2, 2022
@kileys kileys merged commit 13230c8 into apache:master Apr 2, 2022
TheNeuralBit added a commit to TheNeuralBit/beam that referenced this pull request May 2, 2022
This reverts commit 13230c8, reversing
changes made to 25e6756.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants