Skip to content

[BEAM-14241] Address staticcheck warnings in boot.go #17264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostluck merged 1 commit into from
Apr 4, 2022
Merged

[BEAM-14241] Address staticcheck warnings in boot.go #17264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sdks/go/container/boot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func getGoWorkerArtifactName(artifacts []*pipepb.ArtifactInformation) (string, e

switch len(artifacts) {
case 0:
return "", errors.New(fmt.Sprintf("No artifacts staged"))
return "", errors.New("no artifacts staged")
case 1:
name, _ = artifact.MustExtractFilePayload(artifacts[0])
return name, nil
Expand All @@ -139,7 +139,7 @@ func getGoWorkerArtifactName(artifacts []*pipepb.ArtifactInformation) (string, e
return n, nil
}
}
return "", errors.New(fmt.Sprintf("No artifact named '%v' found", worker))
return "", fmt.Errorf("no artifact named '%v' found", worker)
}
}

Expand All @@ -156,13 +156,13 @@ func ensureEndpointsSet(info *fnpb.ProvisionInfo) error {
}

if *loggingEndpoint == "" {
return errors.New("No logging endpoint provided.")
return errors.New("no logging endpoint provided")
}
if *artifactEndpoint == "" {
return errors.New("No artifact endpoint provided.")
return errors.New("no artifact endpoint provided")
}
if *controlEndpoint == "" {
return errors.New("No control endpoint provided.")
return errors.New("no control endpoint provided")
}

return nil
Expand Down