Skip to content

Conversation

@jrmccluskey
Copy link
Contributor

@jrmccluskey jrmccluskey commented Apr 4, 2022

Adds the ProcessContinuation interface to the Go SDK and adds handling for it to be a valid return value in funcx/fn.go. Also adds a unit test case for the new return type.

Design Doc: https://docs.google.com/document/d/1_JbzjY9JR07ZK5v7PcZevUfzHPsqwzfV7W6AouNpMPk/edit?usp=sharing


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Apr 4, 2022

Can one of the admins verify this patch?

3 similar comments
@asf-ci
Copy link

asf-ci commented Apr 4, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Apr 4, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Apr 4, 2022

Can one of the admins verify this patch?

@github-actions github-actions bot added the go label Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #17265 (682a8ff) into master (4213f9e) will decrease coverage by 0.06%.
The diff coverage is 61.90%.

@@            Coverage Diff             @@
##           master   #17265      +/-   ##
==========================================
- Coverage   74.16%   74.09%   -0.07%     
==========================================
  Files         675      679       +4     
  Lines       88896    89087     +191     
==========================================
+ Hits        65926    66010      +84     
- Misses      21835    21926      +91     
- Partials     1135     1151      +16     
Flag Coverage Δ
go 50.06% <61.90%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/funcx/fn.go 58.10% <38.46%> (+0.56%) ⬆️
sdks/go/pkg/beam/core/sdf/continuation.go 100.00% <100.00%> (ø)
sdks/go/pkg/beam/core/runtime/graphx/dataflow.go 53.93% <0.00%> (-1.39%) ⬇️
sdks/go/pkg/beam/core/runtime/exec/coder.go 56.46% <0.00%> (-0.47%) ⬇️
sdks/go/pkg/beam/core/runtime/graphx/coder.go 53.72% <0.00%> (-0.39%) ⬇️
sdks/go/pkg/beam/core/typex/fulltype.go 41.83% <0.00%> (-0.34%) ⬇️
sdks/go/pkg/beam/core/runtime/harness/harness.go 10.96% <0.00%> (-0.30%) ⬇️
.../go/pkg/beam/core/runtime/harness/worker_status.go 51.16% <0.00%> (ø)
sdks/go/pkg/beam/core/sdf/lock.go 0.00% <0.00%> (ø)
sdks/go/pkg/beam/core/graph/coder/nil.go 59.09% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4213f9e...682a8ff. Read the comment docs.

@jrmccluskey
Copy link
Contributor Author

Not sure what fmt is catching here, it's not a file I touched and running fmt on the offending file (core/typex/special.go) is not changing anything.

@jrmccluskey
Copy link
Contributor Author

PR to fix the fmt break at #17266

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@jrmccluskey
Copy link
Contributor Author

assign set of reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

R: @lostluck for final approval

@damccorm
Copy link
Contributor

damccorm commented Apr 4, 2022

The bot was a little overeager, happy to have @lostluck weigh in though :) I put up a one liner fix for the bot issue fwiw

@lostluck
Copy link
Contributor

lostluck commented Apr 5, 2022

Please add a link to the design doc in the top description. Makes things a bit more accessible than indirecting to the JIRA (which isn't always as discoverable as one might hope).

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good TBH. A few comments/changes on this pass.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at this point, other than the suggested edits. Errors don't have to be pithy and short. We can add more information, like links to the jira, which when resolved will indicate which release starts supporting the feature.

Co-authored-by: Robert Burke <lostluck@users.noreply.github.com>
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lostluck lostluck merged commit 9e4c288 into apache:master Apr 7, 2022
@jrmccluskey jrmccluskey deleted the processContinuation branch May 12, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants